From owner-freebsd-arch@FreeBSD.ORG  Tue Apr 26 04:11:24 2011
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6C35A1065670
	for <arch@FreeBSD.org>; Tue, 26 Apr 2011 04:11:24 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 27F1C8FC15
	for <arch@FreeBSD.org>; Tue, 26 Apr 2011 04:11:24 +0000 (UTC)
Received: from [10.0.0.63] (63.imp.bsdimp.com [10.0.0.63])
	(authenticated bits=0)
	by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id p3Q47bjG027246
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO);
	Mon, 25 Apr 2011 22:07:38 -0600 (MDT) (envelope-from imp@bsdimp.com)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <BANLkTi=gpjLB_nb2StJPbqKXtEhu9Zu9YA@mail.gmail.com>
Date: Mon, 25 Apr 2011 22:07:36 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <D89CFB81-32E3-4606-BB34-52F54D57149A@bsdimp.com>
References: <7DC6C171-3802-4B5D-B2D8-2191C6FF6DBA@neville-neil.com>
	<BANLkTi=gpjLB_nb2StJPbqKXtEhu9Zu9YA@mail.gmail.com>
To: Ryan Stone <rysto32@gmail.com>
X-Mailer: Apple Mail (2.1084)
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(harmony.bsdimp.com [10.0.0.6]);
	Mon, 25 Apr 2011 22:07:39 -0600 (MDT)
Cc: arch@FreeBSD.org, George Neville-Neil <gnn@neville-neil.com>
Subject: Re: Is there any reason not to remove all the spl() calls in
	rtsock.c?
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2011 04:11:24 -0000


On Apr 25, 2011, at 8:09 PM, Ryan Stone wrote:

> On Mon, Apr 25, 2011 at 9:59 PM, George Neville-Neil
> <gnn@neville-neil.com> wrote:
>> Howdy,
>>=20
>> I was just reviewing the code in rtsock.c, specifically rts_attach(). =
 Is there any reason
>> not to just remove the spl* calls?  I don't see anything obvious that =
needs protection
>> that is not now protected by a finer grained lock.

Likely they can go.  Only reason to keep them at all at this point is if =
there's still stuff that isn't locked, which should be only a tiny =
fraction of the tree...

Warner

>>=20
>> Best,
>> George
>=20
> The spl* calls have been no-ops for over 10 years now(since r71240),
> so I certainly hope that there's nothing requiring their protection.
>=20
> It's probably long-past time to kill off those stubs, I'd imagine.
> _______________________________________________
> freebsd-arch@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-arch
> To unsubscribe, send any mail to =
"freebsd-arch-unsubscribe@freebsd.org"
>=20
>=20