From owner-freebsd-audit Fri Aug 10 15:44:44 2001 Delivered-To: freebsd-audit@freebsd.org Received: from beppo.feral.com (beppo.feral.com [192.67.166.79]) by hub.freebsd.org (Postfix) with ESMTP id E6C7A37B403; Fri, 10 Aug 2001 15:44:40 -0700 (PDT) (envelope-from mjacob@feral.com) Received: from wonky.feral.com (wonky.feral.com [192.67.166.7]) by beppo.feral.com (8.11.3/8.11.3) with ESMTP id f7AMieI35125; Fri, 10 Aug 2001 15:44:40 -0700 (PDT) (envelope-from mjacob@feral.com) Date: Fri, 10 Aug 2001 15:44:33 -0700 (PDT) From: Matthew Jacob Reply-To: To: Bill Paul Cc: Subject: Re: Need reviewers for busdma changes to ethernet driver In-Reply-To: <20010809184152.8A95F37B401@hub.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Seems mostly good. 1. Nit: /* * Obtain the physical addresses of the RX and TX * rings which we'll need later in the init routine. */ More formally, it's not a 'physical address'- it's a "Bus Address", or "Address appropriate for a device on this bus to use to access the memory so mapped". Under sparc64, for example, it would be an iommu mapping address. 2. All callback functions for dma- you should be checking error. 3. You might want to recycle rather than create/destroy mbuf tags. You should note that FreeBSD's bus_dma is hardly as strict or as formal as NetBSD's, so there's room for a lot of slop here. The key thing to test it on is an alpha that has both direct-mapped and sgmap hardware to see that it works. -matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message