From owner-cvs-all@FreeBSD.ORG  Wed Apr 14 08:42:29 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C17F016A4D0
	for <cvs-all@FreeBSD.org>; Wed, 14 Apr 2004 08:42:29 -0700 (PDT)
Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5F3AE43D39
	for <cvs-all@FreeBSD.org>; Wed, 14 Apr 2004 08:42:29 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 16959 invoked from network); 14 Apr 2004 15:42:25 -0000
Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx)
	([216.27.160.63])          (envelope-sender <jhb@FreeBSD.org>)
	encrypted SMTP
	for <cvs-all@FreeBSD.org>; 14 Apr 2004 15:42:25 -0000
Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i3EFfYe0001084;
	Wed, 14 Apr 2004 11:42:06 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
From: John Baldwin <jhb@FreeBSD.org>
To: Mark Murray <markm@FreeBSD.org>
Date: Tue, 13 Apr 2004 22:58:31 -0400
User-Agent: KMail/1.6
References: <200404120913.i3C9DOkd075451@repoman.freebsd.org>
In-Reply-To: <200404120913.i3C9DOkd075451@repoman.freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200404132258.31816.jhb@FreeBSD.org>
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/random randomdev.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 15:42:30 -0000

On Monday 12 April 2004 05:13 am, Mark Murray wrote:
> markm       2004/04/12 02:13:24 PDT
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/dev/random       randomdev.c
>   Log:
>   Fix "sleeping without a mutex" panic.

You should drop the lock before uiomove().  If the uio can possibly reference 
user memory, then uiomove() will do a copyout() which can fault and thus 
sleep if the page is in swap.

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org