From owner-freebsd-bugs@freebsd.org Sun Jun 2 14:43:42 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D356415B774E for ; Sun, 2 Jun 2019 14:43:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 62F566BB45 for ; Sun, 2 Jun 2019 14:43:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 1C92315B774D; Sun, 2 Jun 2019 14:43:41 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA87C15B774C for ; Sun, 2 Jun 2019 14:43:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E38B6BB42 for ; Sun, 2 Jun 2019 14:43:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 994D6CB04 for ; Sun, 2 Jun 2019 14:43:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x52EhdE9096727 for ; Sun, 2 Jun 2019 14:43:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x52Ehdo5096726 for bugs@FreeBSD.org; Sun, 2 Jun 2019 14:43:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 238291] [patch] Elantech touchpad device is not recognized on Thinkpad t480s (error: unknown touchpad firmware (firmware v.0x7f3001)) Date: Sun, 02 Jun 2019 14:43:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: Andrey.Kosachenko@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jun 2019 14:43:42 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238291 Bug ID: 238291 Summary: [patch] Elantech touchpad device is not recognized on Thinkpad t480s (error: unknown touchpad firmware (firmware v.0x7f3001)) Product: Base System Version: 12.0-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: Andrey.Kosachenko@gmail.com Created attachment 204782 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D204782&action= =3Dedit enables proper t480s touchpad fw version recognition Hi, originally was reported in freebsd-drivers (https://lists.freebsd.org/pipermail/freebsd-drivers/2019-May/002183.html) Further was suggested to submit a PR. Recently I've replaced my t410 with t480s model. Before ordering the device I found positive feedback in terms of FreeBSD=20 compatibility (pages like https://wiki.freebsd.org/Laptops/Thinkpad_T480) Apparently device is equipped with newer clickpad+trackpoint device=20 which is not recognized by 12R properly: FreeBSD beastie.intra 12.0-RELEASE-p3 FreeBSD 12.0-RELEASE-p3 #2=20 r347114M: Sun May 12 00:08:31 EEST 2019=20 root at beastie.intra:/usr/obj/usr/src/amd64.amd64/sys/BEASTIE-EVDEV amd64 Attempts to enable hw.psm.synaptics_support or(and)=20 hw.psm.elantech_support didn't help either. Though trackpoint works=20 just fine after enabling hw.psm.trackpoint_support instead touchpad is recognized as generic PS/2 mouse (relevant strings=20 from dmesg) =3D=3D=3D May 11 22:39:41 beastie kernel: atkbd0: [GIANT-LOCKED] May 11 22:39:41 beastie kernel: Unknown touchpad hardware (firmware=20 v.0x7f3001) May 11 22:39:41 beastie kernel: psm0: irq 12 on atkbdc0 May 11 22:39:41 beastie kernel: psm0: [GIANT-LOCKED] May 11 22:39:41 beastie kernel: psm0: model Generic PS/2 mouse, device ID 0 =3D=3D=3D I was pretty much happy working with the device in general and with the=20 tuouchpad in particular (as a simple mouse). Even got accustomed to the=20 absence of double-finger scroll capability (which I could simulate via=20 holding mid-button+swipe on touchpad) and triple-finger-tap as a=20 midle-button-click). The only thing that I failed to workaround was=20 accidental palm touches which is really painful and makes keyboard usage=20 unbearable. Eventually I tried to seek for normal solution. Lenovo site sujests for t480s devices "ELAN UltraNav Driver for Windows=20 10 64-bit - ThinkPad T480s (Type 20L7, 20L8)" driver. Which made me=20 think it is elantech (not synaptics). Looking through the psm sources=20 quickly led me to the point where a very simple modification and=20 recompilation of the kernel helped to recognize touchpad properly: =3D=3D=3D [silent at beastie][/usr/src]dmesg | egrep psm psm0: irq 12 on atkbdc0 psm0: [GIANT-LOCKED] psm0: model Elantech Touchpad, device ID 0 =3D=3D=3D Additionally I found relevant topic in openbsd lists=20 http://openbsd-archive.7691.n7.nabble.com/ThinkPad-T480s-Elantech-v4-clickp= ad-configuration-td342242.html.=20 Eventually I narrow down it to the following changes:=20 https://github.com/openbsd/src/commit/8e9e9c10431cb45d93e2c0d81f668ff9575f8= 015#diff-ff06b79b08490ebbfa34b15aa4ebf370=20 Also in the freebsd-drivers Vladimir Kondratyev commented the following (https://lists.freebsd.org/pipermail/freebsd-drivers/2019-May/002189.html): =3D=3D=3D The patch looks good to me. Linux guys did exactly the same recently: https://github.com/torvalds/linux/commit/10d900303f1c3a821eb0bef4e7b7ece167= 68fba4#diff-e91bc4802c6797fe9acbdca0ed240be9 =3D=3D=3D PS: Please note there are 3 issues described in the mentioned thread of mailing lists: 1) proper touchpad firmware recognition 2) trackpoint issue; 3) yet unknown error reported in Xorg log this PR is dedicated to issue #1 only from the list above Thank you! --=20 You are receiving this mail because: You are the assignee for the bug.=