From owner-svn-src-all@freebsd.org Thu Jul 5 14:58:44 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA7361030C69; Thu, 5 Jul 2018 14:58:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 97206810B4; Thu, 5 Jul 2018 14:58:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 34F1310AFD4; Thu, 5 Jul 2018 10:58:42 -0400 (EDT) Subject: Re: svn commit: r335888 - in head: contrib/blacklist/bin lib/libpjdlog sbin/hastd To: Ed Maste , Eitan Adler References: <201807031353.w63DrsAa079940@repo.freebsd.org> <980f862d-02d0-a1ce-cf4c-1d39021013fb@FreeBSD.org> <20180703150203.GA34086@bsdpad.com> Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: John Baldwin Message-ID: Date: Thu, 5 Jul 2018 07:58:41 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Thu, 05 Jul 2018 10:58:42 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 14:58:44 -0000 On 7/4/18 7:25 PM, Ed Maste wrote: > On 4 July 2018 at 20:55, Eitan Adler wrote: >> On Tue, 3 Jul 2018 at 08:22, John Baldwin wrote: >>> >> since GCC usually breaks >>> them. >> >> Could you explain what you mean or point to a prior conversation? >> > I'm not sure if there's a previous discussion, but the short version > is that the GCC build process includes a 'fixincludes' step which > installs modified versions of system headers in some path that GCC > uses in preference to /usr/include. Originally this was done to work > around broken system includes in proprietary operating systems that > couldn't easily be fixed upstream. In the case of FreeBSD GCC's > fixincludes actually just installs broken headers, and removing its > broken copies is the easy fix. Worse, the headers in include-fixed don't get updated if you install a new world with updated system headers, so you can get weird compile issues because GCC from ports is using stale copies of headers. It's generally a hack for ancient OS's that isn't relevant on FreeBSD. The issues that fixincludes thinks it finds and needs to fix aren't legitimate issues AFAIK (and if they were we'd want to fix our real headers instead). -- John Baldwin