From owner-svn-src-stable-8@FreeBSD.ORG Mon Nov 7 11:42:59 2011 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A5754106564A; Mon, 7 Nov 2011 11:42:59 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id 33CFE8FC0A; Mon, 7 Nov 2011 11:42:58 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.4/8.14.4/ALCHEMY.FRANKEN.DE) with ESMTP id pA7BgpVa093811; Mon, 7 Nov 2011 12:42:51 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.4/8.14.4/Submit) id pA7Bgp2w093810; Mon, 7 Nov 2011 12:42:51 +0100 (CET) (envelope-from marius) Date: Mon, 7 Nov 2011 12:42:51 +0100 From: Marius Strobl To: Jason Hellenthal Message-ID: <20111107114251.GA93221@alchemy.franken.de> References: <201111062109.pA6L9OLV042060@svn.freebsd.org> <20111107020759.GA45996@DataIX.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111107020759.GA45996@DataIX.net> User-Agent: Mutt/1.4.2.3i Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r227278 - in stable/8/sys: arm/conf conf dev/bm dev/dc dev/mii dev/nge dev/sis dev/smc dev/ste dev/stge dev/tl dev/wb dev/xl modules/mii pci X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2011 11:42:59 -0000 On Sun, Nov 06, 2011 at 09:07:59PM -0500, Jason Hellenthal wrote: > > > The following commmit broke building without device miibus at least on i386. > > if_dc.o(.text+0x24b4): In function `dc_miibus_writereg': > /usr/src/sys/dev/dc/if_dc.c:806: undefined reference to `mii_bitbang_writereg' > if_dc.o(.text+0x26cc): In function `dc_miibus_readreg': > /usr/src/sys/dev/dc/if_dc.c:743: undefined reference to `mii_bitbang_readreg' > > If you try to use the modular device mii and the single *phy you will get the above error when it comes time to link the kernel. Yes, you now need to additionally put "options mii_bitbang" into your kernel configuration file if you don't use "options miibus" but "options mii" and individual PHY drivers in combination with one of the MAC drivers that where converted to use the common MII bitbang'ing code, see sys/conf/NOTES. Given that this is a rather exotic approach intended for embedded use it didn't occur to me to note it beyond NOTES. However, thinking about it I decided for stable/7 and stable/8 to automatically drag in the common MII bitbang'ing code if one of the MAC drivers depending on it is compiled into the kernel in order to not break POLA. Marius