From owner-svn-src-all@freebsd.org Fri May 4 16:20:52 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72BA2FB1537; Fri, 4 May 2018 16:20:52 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: from mail-ot0-x242.google.com (mail-ot0-x242.google.com [IPv6:2607:f8b0:4003:c0f::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0126F7EEF0; Fri, 4 May 2018 16:20:52 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: by mail-ot0-x242.google.com with SMTP id l22-v6so25114708otj.0; Fri, 04 May 2018 09:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=5okFOr+OecUDRqzcjddo/dR//BcR+R+IFvb1yJ2+M2I=; b=oBrqdjNKYxQ7KfdVolkNBv9eMy1Exgc20u/67NCMKtHcZGmFvGCTEQwNSvGl7t6ees 7XSIBOdwStMyy0E3sxJLeq5yWZ7ShKVzbxwzRmR9jIn6LeQtMfa0SqqLyeDwttr2vp/y d6v51DsxFST4wyZyi0T5QOULw4oJYJJryfKRjrKBTa5ubqyaE1Hvm0RWoOf+TV3D3Y7v t4SJQp/EutOL3xWBqTzr4uHBiCtgMMUVqXiwUnGNnS5JWy4Jz07OIX/LXc/gNFslihCn fH9B/iiG+O6DZYb1hPD+TwssX27jvRX2ZwF6kmVeTYpDrtuC0U9o9dd4zOWP9bF2Z2wM bzCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=5okFOr+OecUDRqzcjddo/dR//BcR+R+IFvb1yJ2+M2I=; b=UIrO9QGxa/rvhhp7iyjAbKc7aJns7hDcYxpQYOHEDWKV/+hsWIncxRQE7GV6/P3rSb 5iXIEnhadDnkv5uTa5H4/C1NCt9ptlsob7SrhJsFeYeZY6zlXIDTzv8ycrjv3x1QkXhN +0aGvHZGtcM4efSLWCIYydCR4huroeP1n4l0lsly7cnKQm+1bJZ2c6KcMaWcv0bNQuuk y9YidvDDCnq+rVtYWkLDWsqUDfYOcFwXRcJEqXyHkJku9Je98VX6yd2OE9K18PKT3fkc 3/bT9uPSvdfp4BujWeYoGJTyi9tnfXMzR9c19MAYEQ6N7/pKAZWoXx/0WDDvjwRqYZ61 eG4Q== X-Gm-Message-State: ALQs6tCND4ljI62rdKJJNvkgEu/n3cclpUiOIiPuBlOeoF/nVDvM3ewZ IOWCuA+eJLqTS2S6NXOM7SzBPXsNdLRKHRpo2KuvaA== X-Google-Smtp-Source: AB8JxZoEbA+NK/U3R6l5Ga4NbtXgNNKVrJmcbkUY1VpYrS18GPtu2r/bfuxeaXfO7aEAAe/GMnO+Df469Ds9ELaci4s= X-Received: by 2002:a9d:3c0a:: with SMTP id q10-v6mr322946otc.39.1525450851124; Fri, 04 May 2018 09:20:51 -0700 (PDT) MIME-Version: 1.0 Sender: kmacybsd@gmail.com Received: by 2002:a9d:3f0:0:0:0:0:0 with HTTP; Fri, 4 May 2018 09:20:50 -0700 (PDT) In-Reply-To: <201805041407.w44E7EHg042498@pdx.rh.CN85.dnsmgr.net> References: <201805040651.w446p2iB010839@repo.freebsd.org> <201805041407.w44E7EHg042498@pdx.rh.CN85.dnsmgr.net> From: "K. Macy" Date: Fri, 4 May 2018 09:20:50 -0700 X-Google-Sender-Auth: V1EKBN9iHKrLEhw-HC-7c8LDPVs Message-ID: Subject: Re: svn commit: r333242 - head/sys/kern To: rgrimes@freebsd.org Cc: Matt Macy , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 16:20:52 -0000 Yes. Good catch. Thanks. -M > > Missing Approved by: sbruno? > > >> Modified: >> head/sys/kern/kern_descrip.c >> >> Modified: head/sys/kern/kern_descrip.c >> ============================================================================== >> --- head/sys/kern/kern_descrip.c Fri May 4 04:05:07 2018 (r333241) >> +++ head/sys/kern/kern_descrip.c Fri May 4 06:51:01 2018 (r333242) >> @@ -1503,7 +1503,7 @@ filecaps_copy(const struct filecaps *src, struct filec >> >> if (src->fc_ioctls != NULL && !locked) >> return (false); >> - *dst = *src; >> + memcpy(dst, src, sizeof(*src)); >> if (src->fc_ioctls == NULL) >> return (true); >> >> @@ -1512,7 +1512,7 @@ filecaps_copy(const struct filecaps *src, struct filec >> >> size = sizeof(src->fc_ioctls[0]) * src->fc_nioctls; >> dst->fc_ioctls = malloc(size, M_FILECAPS, M_WAITOK); >> - bcopy(src->fc_ioctls, dst->fc_ioctls, size); >> + memcpy(dst->fc_ioctls, src->fc_ioctls, size); >> return (true); >> } >> >> >> > > -- > Rod Grimes rgrimes@freebsd.org > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"