From owner-svn-src-head@FreeBSD.ORG Sun Jan 4 22:14:17 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 47DAC1065733; Sun, 4 Jan 2009 22:14:17 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 241E08FC1B; Sun, 4 Jan 2009 22:14:17 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id B3DD346B17; Sun, 4 Jan 2009 17:14:16 -0500 (EST) Date: Sun, 4 Jan 2009 22:14:16 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Ed Schouten In-Reply-To: <20090104220716.GL14235@hoeg.nl> Message-ID: References: <200901042153.n04LrgkD075147@svn.freebsd.org> <20090104220716.GL14235@hoeg.nl> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186751 - in head/sys: netinet6 netipsec X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jan 2009 22:14:17 -0000 On Sun, 4 Jan 2009, Ed Schouten wrote: > * Robert Watson wrote: >> Unlike with struct protosw, several instances of struct ip6protosw >> did not use C99-style sparse structure initialization, so remove >> NULL assignments for now-removed pr_usrreq function pointers. > > Maybe we should convert them to use the C99-style initialisation. This could > prevent similar issues in the future, right? I think Bjoern already has a work-in-progress on this one, but yes, that would be a good idea. Robert N M Watson Computer Laboratory University of Cambridge