From owner-p4-projects@FreeBSD.ORG  Fri Apr 13 05:12:17 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id BEBB816A404; Fri, 13 Apr 2007 05:12:16 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 716D316A401
	for <perforce@freebsd.org>; Fri, 13 Apr 2007 05:12:16 +0000 (UTC)
	(envelope-from scottl@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 6359A13C465
	for <perforce@freebsd.org>; Fri, 13 Apr 2007 05:12:16 +0000 (UTC)
	(envelope-from scottl@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3D5CGqa034984
	for <perforce@freebsd.org>; Fri, 13 Apr 2007 05:12:16 GMT
	(envelope-from scottl@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3D5CGQA034970
	for perforce@freebsd.org; Fri, 13 Apr 2007 05:12:16 GMT
	(envelope-from scottl@freebsd.org)
Date: Fri, 13 Apr 2007 05:12:16 GMT
Message-Id: <200704130512.l3D5CGQA034970@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	scottl@freebsd.org using -f
From: Scott Long <scottl@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 117988 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Apr 2007 05:12:17 -0000

http://perforce.freebsd.org/chv.cgi?CH=117988

Change 117988 by scottl@scottl-y1 on 2007/04/13 05:11:35

	Drop the periph lock around calling make_dev

Affected files ...

.. //depot/projects/scottl-camlock/src/sys/cam/scsi/scsi_ch.c#10 edit
.. //depot/projects/scottl-camlock/src/sys/cam/scsi/scsi_ses.c#12 edit
.. //depot/projects/scottl-camlock/src/sys/cam/scsi/scsi_sg.c#5 edit

Differences ...

==== //depot/projects/scottl-camlock/src/sys/cam/scsi/scsi_ch.c#10 (text+ko) ====

@@ -374,9 +374,11 @@
 			  DEVSTAT_PRIORITY_OTHER);
 
 	/* Register the device */
+	cam_periph_unlock(periph);
 	softc->dev = make_dev(&ch_cdevsw, periph->unit_number, UID_ROOT,
 			      GID_OPERATOR, 0600, "%s%d", periph->periph_name,
 			      periph->unit_number);
+	cam_periph_lock(periph);
 	softc->dev->si_drv1 = periph;
 
 	/*

==== //depot/projects/scottl-camlock/src/sys/cam/scsi/scsi_ses.c#12 (text+ko) ====

@@ -364,9 +364,11 @@
 		return (CAM_REQ_CMP_ERR);
 	}
 
+	cam_periph_unlock(periph);
 	softc->ses_dev = make_dev(&ses_cdevsw, unit2minor(periph->unit_number),
 	    UID_ROOT, GID_OPERATOR, 0600, "%s%d",
 	    periph->periph_name, periph->unit_number);
+	cam_periph_lock(periph);
 	softc->ses_dev->si_drv1 = periph;
 
 	/*

==== //depot/projects/scottl-camlock/src/sys/cam/scsi/scsi_sg.c#5 (text+ko) ====

@@ -319,11 +319,13 @@
 			DEVSTAT_PRIORITY_PASS);
 
 	/* Register the device */
+	cam_periph_unlock(periph);
 	softc->dev = make_dev(&sg_cdevsw, unit2minor(periph->unit_number),
 			      UID_ROOT, GID_OPERATOR, 0600, "%s%d",
 			      periph->periph_name, periph->unit_number);
 	softc->devalias = make_dev_alias(softc->dev, "sg%c",
 					 'a' + periph->unit_number);
+	cam_periph_lock(periph);
 	softc->dev->si_drv1 = periph;
 
 	/*