From owner-freebsd-acpi@FreeBSD.ORG  Sun Jun 21 16:27:32 2009
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5BC98106564A
	for <freebsd-acpi@freebsd.org>; Sun, 21 Jun 2009 16:27:32 +0000 (UTC)
	(envelope-from freebsdusb@bindone.de)
Received: from mail.bindone.de (mail.bindone.de [80.190.134.51])
	by mx1.freebsd.org (Postfix) with SMTP id 9E16E8FC18
	for <freebsd-acpi@freebsd.org>; Sun, 21 Jun 2009 16:27:31 +0000 (UTC)
	(envelope-from freebsdusb@bindone.de)
Received: (qmail 91182 invoked by uid 89); 21 Jun 2009 16:27:30 -0000
Received: from unknown (HELO ufo.bindone.de) (mg@bindone.de@87.152.188.39)
	by mail.bindone.de with ESMTPA; 21 Jun 2009 16:27:30 -0000
Message-ID: <4A3E5F40.4040709@bindone.de>
Date: Sun, 21 Jun 2009 18:26:40 +0200
From: Michael <freebsdusb@bindone.de>
User-Agent: Thunderbird 2.0.0.17pre (X11/20090202)
MIME-Version: 1.0
To: Rui Paulo <rpaulo@freebsd.org>
References: <4A3E1784.2050406@bindone.de>
	<5AFA3C27-D3DB-48DA-9AF3-9E14D11EEC61@freebsd.org>
	<C0DCC4DA-5E4C-46B2-9B84-4EBBC5920B3D@freebsd.org>
In-Reply-To: <C0DCC4DA-5E4C-46B2-9B84-4EBBC5920B3D@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-acpi@freebsd.org
Subject: Re: Two new acpi modules, acpi_wmi and acpi_hp
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jun 2009 16:27:32 -0000

Rui Paulo wrote:
> On 21 Jun 2009, at 15:08, Rui Paulo wrote:
> 
>> On 21 Jun 2009, at 12:20, Michael wrote:
>>
>>> Hello,
>>>
>>> I wrote two new acpi modules last year and finally found the time to fix
>>> them, add some missing features and write man pages.
>>
>> Michael, this is great work! I'll review and see if we can ship it
>> with 8.0!
> 
> Michael, this looks good, but there are two style nits that we need to fix.
> * we should try not going over the 80 column mark
> * add a empty new line before every return
> 
> If you could send me a new patch for 8.0 with these fixes, I'll commit
> it (unless someone else has objections).
> 
> Regards,
> -- 
> Rui Paulo
> 

Hi Rui,

hmm style(9) doesn't say anything about columns or return statements in
this context (maybe it should be updated?!?).

Anyway, when saying adding an empty line before every return statement,
do you also mean conditional return statements:

So e.g.

int func()
{
  int a;

  if (!a)
	return 0;
  return 1;
}

Should be:


int func()
{
  int a;

  if (!a)

	return 0;

  return 1;
}

or

int func()
{
  int a;

  if (!a) {

	return 0;
  }

  return 1;
}
??
Thanks
Michael