Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Jul 2008 03:08:51 GMT
From:      "Pedro F. Giffuni" <pfgshield-freebsd@yahoo.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/125459: Add regression-test target for lang/python25
Message-ID:  <200807100308.m6A38pcY032998@www.freebsd.org>
Resent-Message-ID: <200807100310.m6A3A2Gm004385@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         125459
>Category:       ports
>Synopsis:       Add regression-test target for lang/python25
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 10 03:10:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Pedro F. Giffuni
>Release:        6-3-Release
>Organization:
>Environment:
FreeBSD kakumen.cable.net.co 6.3-RELEASE FreeBSD 6.3-RELEASE #10: Sat Jan 19 01:13:55 COT 2008     root@kakumen.cable.net.co:/usr/src/sys/amd64/compile/SMP  amd64

>Description:
No functional change.

The tests take a while but python is a rather critical port. 

I am strongly tempted to leave the tests out of the MAINTAINER_MODE (so they would be run by pointyhat) but I leave that decision to the maintainer(s)
>How-To-Repeat:
The motivation for the PR was provided by this posting of a problem found while running the tests:

http://docs.freebsd.org/cgi/mid.cgi?20080709142332.GB68329
>Fix:
diff -ruN python25.orig/Makefile python25/Makefile
--- python25.orig/Makefile	2008-07-09 21:11:18.000000000 -0500
+++ python25/Makefile	2008-07-09 21:55:52.000000000 -0500
@@ -178,6 +178,11 @@
 .endfor
 .endfor
 
+.ifdef MAINTAINER_MODE
+regression-test: build
+	@cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE} test
+.endif
+
 pre-install:
 	${CAT} ${PLIST_TEMPLATE} | ${AWK} '{ print $$0; } \
 	/LIBDIR.*\.py$$/ && !/\/bad/ { print $$0 "o"; print $$0 "c"; }'	> ${PLIST}


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807100308.m6A38pcY032998>