From owner-cvs-all Sat Sep 25 13:24: 7 1999 Delivered-To: cvs-all@freebsd.org Received: from picalon.gun.de (picalon.gun.de [194.77.0.18]) by hub.freebsd.org (Postfix) with ESMTP id 99E9914D4E; Sat, 25 Sep 1999 13:23:53 -0700 (PDT) (envelope-from andreas@klemm.gtn.com) Received: from klemm.gtn.com (pppak04.gtn.com [194.231.123.169]) by picalon.gun.de (8.9.3/8.9.3) with ESMTP id WAA25426; Sat, 25 Sep 1999 22:23:50 +0200 (MET DST) Received: (from andreas@localhost) by klemm.gtn.com (8.9.3/8.9.3) id WAA00829; Sat, 25 Sep 1999 22:00:03 +0200 (CEST) (envelope-from andreas) Date: Sat, 25 Sep 1999 22:00:03 +0200 From: Andreas Klemm To: Satoshi - Ports Wraith - Asami Cc: Andreas Klemm , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/print/apsfilter Makefile Message-ID: <19990925220003.A803@titan.klemm.gtn.com> References: <199909251711.KAA00809@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0pre1i In-Reply-To: X-Operating-System: FreeBSD 4.0-CURRENT SMP X-Disclaimer: A free society is one where it is safe to be unpopular Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sat, Sep 25, 1999 at 10:23:37AM -0700, Satoshi - Ports Wraith - Asami wrote: > * Modified files: > * print/apsfilter Makefile > * Log: > * added configure script with dialog utility like in apache13-php3 port, > * that offers the user a menue, where he enters > * - PAPERSIZE > * - file type support for apsfilter > > Thanks, but why are you putting the generated Makefile.inc in > ${WRKDIRPREFIX}${.CURDIR} instead of ${WRKDIR}? The latter will > surely make your Makefile much simpler. As far as I guess right ${WRKDIRPREFIX}${.CURDIR} != ${WRKDIR} I think ${WRKDIRPREFIX}${.CURDIR}/work = ${WRKDIR} > Actually I don't even understand why you just didn't use pre-clean > instead of copying the entire "clean" target from bsd.port.mk (which > is usually not a very good idea) just to add a post-clean like > functionality. ;) Hmm, perhaps I'll use pre-clean in the future. Thanks for reminding me. But this evening I don't change it any further, since tomorrow I'll be away for a week. No quick shot where at least I might overlook something ;-) Andreas /// -- Andreas Klemm http://www.FreeBSD.ORG/~andreas http://www.freebsd.org/~fsmp/SMP/SMP.html powered by Symmetric MultiProcessor FreeBSD Get new songs from our band: http://www.freebsd.org/~andreas/64bits/index.html To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message