From owner-svn-src-head@freebsd.org  Wed Mar  8 04:33:20 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67888D00F34;
 Wed,  8 Mar 2017 04:33:20 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E5E8B15D3;
 Wed,  8 Mar 2017 04:33:19 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v284XIfK098482;
 Tue, 7 Mar 2017 20:33:18 -0800 (PST)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v284XICJ098481;
 Tue, 7 Mar 2017 20:33:18 -0800 (PST) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201703080433.v284XICJ098481@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r314891 - head/sys/boot/efi/loader
In-Reply-To: <201703080250.v282oTDF096183@repo.freebsd.org>
To: Dexuan Cui <dexuan@freebsd.org>
Date: Tue, 7 Mar 2017 20:33:18 -0800 (PST)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Mar 2017 04:33:20 -0000

[ Charset UTF-8 unsupported, converting... ]
> Author: dexuan
> Date: Wed Mar  8 02:50:29 2017
> New Revision: 314891
> URL: https://svnweb.freebsd.org/changeset/base/314891
> 
> Log:
>   loader.efi: finally fix the off-by-one bug in efi_verify_staging_size()
>   
>   r314828(loader.efi: fix an off-by-one bug in efi_verify_staging_size())
>   doesn't really fix the bug and this patch adds the missing part.
>   
>   It's a shame that I didn't make everything correct at the very beginning...

My thoughts on that:

Try as hard as we can and you well come up short on making software
correct in the beginning as it is an iterative process.  Be glad you
have found and fixed yet another small problem, and hope that in
doing so you have not introduced another.

I thank you for your persuit of this latent issue in loader.efi!

-- 
Rod Grimes                                                 rgrimes@freebsd.org