From owner-freebsd-current@freebsd.org Sun Jan 31 04:56:25 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3BECFA73AA2 for ; Sun, 31 Jan 2016 04:56:25 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-oi0-x22c.google.com (mail-oi0-x22c.google.com [IPv6:2607:f8b0:4003:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EF329DA7 for ; Sun, 31 Jan 2016 04:56:24 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by mail-oi0-x22c.google.com with SMTP id r14so70883590oie.0 for ; Sat, 30 Jan 2016 20:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to; bh=7DBweqWWEi15/hkBSKaiu20NeyFxfcM3vrtvUjLrwVE=; b=xorB6cEIVcFWhwyNgfi+tKVdRqwISoEyiC1kFXsEGRIqXXImf+aSZY/3M2wARxd4PK bjtNePhQAsS5VxW2k4WHJUcR/YL6XQQAiHPRsqJut3AGOll4HyFXyYgBR6/wMgWZwITM pNoSRYclYy8QCSiGlyh3loWe8c29t4inUq9Rnww5ukDdJhBlpVHZ097+LWJVUuz55Cec WFNAA4uUQe2OJmt+sXWm9TN4X0Pl0ouUurxEIzQTGRn9EQFcFhFmD1eOaeg/jf0585j2 gz3H982UrqRBKBrF1WF+J/QbSEBYG2EbQDN17jEAS8GU1O/R7AjIK0Pe57HyZV/6J4r2 m5nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=7DBweqWWEi15/hkBSKaiu20NeyFxfcM3vrtvUjLrwVE=; b=MlTY92uEcB/Xr7N2ir580mYQO5CC4umcHzmkvBoGEoSI0Cp+yDulJ7nEuFeVE7g91K yO8QJzaUhnuBCWh11VYqxehQnc5qqVodDNqnwDsACBJI4UnY5ZoIvSYkGphsa+l/zbVi 0lMc3+JQMQgEAbQjT5L/hWT57j6skECYGHaic6hVdZzBJcGk1IxU1v4bftf2YJY/TNUK ip+oUs7nQR1ovLspRRjl53boztl1ELbQE86fISGd7Gd12P9gd3MXN67SCai92CvU/1bw SH++j2Jv8qUp38eTtAfLbLMjTNvTYZYzVnb36w1VJOUxboj+RDGGT8zu11Vz4iCFpd2j cMEw== X-Gm-Message-State: AG10YOTNKXxx7NdGlyVZM6oTMUOeX6cIHODaNb9RBiZ8P8VrRjgXb0lqq9HHp8q3OesltA== X-Received: by 10.202.44.79 with SMTP id s76mr11240921ois.123.1454216184187; Sat, 30 Jan 2016 20:56:24 -0800 (PST) Received: from netflix-mac-wired.bsdimp.com ([50.253.99.174]) by smtp.gmail.com with ESMTPSA id j201sm11705507oih.19.2016.01.30.20.56.23 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 30 Jan 2016 20:56:23 -0800 (PST) Sender: Warner Losh Subject: Re: thread-unsafety problems as spl*() ones are NOP Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Content-Type: multipart/signed; boundary="Apple-Mail=_48440F40-684A-4CE7-ABC2-DBDBAC77715E"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5.2 From: Warner Losh In-Reply-To: Date: Sat, 30 Jan 2016 21:56:21 -0700 Cc: Ian Lepore , FreeBSD Current Message-Id: <37EC2460-9C4D-46D4-91A1-FA6CE7B0BFB1@bsdimp.com> References: <1454188175.32550.3.camel@freebsd.org> To: mokhi X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jan 2016 04:56:25 -0000 --Apple-Mail=_48440F40-684A-4CE7-ABC2-DBDBAC77715E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 30, 2016, at 9:37 PM, mokhi wrote: >=20 > @imp So you think I should start to put locks there and see what = happens? :) I=E2=80=99d advocate a deeper understanding of the code. splXXX() is for = code path exclusion. Locks are for data protection. These are subtly different = concepts and may cause issues when you try to just blindly replace the splXXX = with a lock. You can start there, but you=E2=80=99ll still need to do = code-path analysis to see what the locks wind up protecting, and then see if there=E2=80=99s = any access to it outside of locked paths. Warner --Apple-Mail=_48440F40-684A-4CE7-ABC2-DBDBAC77715E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWrZP2AAoJEGwc0Sh9sBEAw44P/iBx3u74ep2s/GweTA62DAHS Kg1LJSqMYhkNVBM8Qss18pc0XpPDbWEoQFYsUvh+jN0isB20gomU3CFvkxk1un1Q twJVUIT55rdaqR4kt5Ds/+/oQyQH3B83u8LRvNCn+kHKLeopjttUJidk/gF2gIs1 anohnlTEpSsgU2chRjGPGa7g9+/tuBm44SDjIbuMHjmF5IOHldIkU03jY1e0Yhni wcG28dRhXsJas5OAmK/dJBESHhjnvo/ueciKRcCmiPm2di2LtevLcX0TJ49mFU1u y4US85LmSrLWvbIRBbVI1MNMUZG+zwqd0MrQPYjeBeSgW/FfYZiV49tTIpXRSLhr gFV9eXxRayc/k6asN3G6X06kl1YZlAOgCsul3EdFJU0N3Bw/CrdRVLEynWVRXLbp TXBGV4bHJShgbDBc2zYYVWjLvuTLu5I1cPPXCApy+X3KJm8wpkmWBhhbNZIzjh0y 2aVXeHzovLMZHcrb5UncaFA+jRaZ/m5Z/mqgYZW1WysRm2MsxufksJbFQmLnDyk8 R3T3Qr/5TTndXEiynDG0SOul//K5lYvLIMjvqw9z5xOj++n3UcRUN6zXUFHURpJd w+wPgbKvThn579cY0MxGIjiiC4heM/SHs0+iKNS4/hi/AGq8pAefiUnGTHN4G9wo SGv0MdIBlPlWLtvELq8O =+sh4 -----END PGP SIGNATURE----- --Apple-Mail=_48440F40-684A-4CE7-ABC2-DBDBAC77715E--