From owner-freebsd-alpha Tue Jan 12 09:32:57 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA15773 for freebsd-alpha-outgoing; Tue, 12 Jan 1999 09:32:57 -0800 (PST) (envelope-from owner-freebsd-alpha@FreeBSD.ORG) Received: from outmail.utsunomiya-u.ac.jp (outmail.utsunomiya-u.ac.jp [160.12.196.3]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA15761 for ; Tue, 12 Jan 1999 09:32:51 -0800 (PST) (envelope-from yokota@zodiac.mech.utsunomiya-u.ac.jp) Received: from zodiac.mech.utsunomiya-u.ac.jp (IDENT:gfSiHPKxuo3cmaxinCsQpEhgHO7VSgBP@zodiac.mech.utsunomiya-u.ac.jp [160.12.42.1]) by outmail.utsunomiya-u.ac.jp (8.9.1/8.9.1) with ESMTP id CAA09220; Wed, 13 Jan 1999 02:32:13 +0900 (JST) Received: from zodiac.mech.utsunomiya-u.ac.jp (zodiac.mech.utsunomiya-u.ac.jp [160.12.42.1]) by zodiac.mech.utsunomiya-u.ac.jp (8.7.6+2.6Wbeta7/3.4W/zodiac-May96) with ESMTP id CAA03875; Wed, 13 Jan 1999 02:34:40 +0900 (JST) Message-Id: <199901121734.CAA03875@zodiac.mech.utsunomiya-u.ac.jp> To: mjacob@feral.com cc: alpha@FreeBSD.ORG, yokota@zodiac.mech.utsunomiya-u.ac.jp Subject: Re: broken builds? In-reply-to: Your message of "Tue, 12 Jan 1999 09:14:03 PST." References: Date: Wed, 13 Jan 1999 02:34:39 +0900 From: Kazutaka YOKOTA Sender: owner-freebsd-alpha@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >farrago.feral.com > cd /usr/src/usr.sbin/vidcontrol/ >farrago.feral.com > make >Warning: Object directory not changed from original >/usr/src/usr.sbin/vidcontrol >cc -O -pipe -Wall -c vidcontrol.c >vidcontrol.c: In function `video_mode': >vidcontrol.c:292: warning: `mode' might be used uninitialized in this >function >vidcontrol.c: In function `set_console': >vidcontrol.c:376: warning: cast to pointer from integer of different size >vidcontrol.c: In function `show_mode_info': >vidcontrol.c:494: warning: int format, different type arg (arg 3) >vidcontrol.c:494: warning: int format, different type arg (arg 4) >vidcontrol.c:496: warning: int format, different type arg (arg 3) [...] >I fixed a couple of the vidcontrol errors (don't you you want >address of n, not n?), It must be 'n', not a pointer to 'n'! Would you commit these fixes to kbdcontrol and vidcontrol? I am dealing with a problem in the splash screen code right now. Kazu >but the printf format warnings are not >fixable because size_t is a long on alpha, not an int. > >*** vidcontrol.c.save Tue Jan 12 09:02:27 1999 >--- vidcontrol.c Tue Jan 12 09:11:11 1999 >*************** >*** 289,295 **** > { "VESA_800x600", SW_VESA_800x600 }, > { NULL }, > }; >! unsigned long mode; > int size[3]; > int i; > >--- 289,295 ---- > { "VESA_800x600", SW_VESA_800x600 }, > { NULL }, > }; >! unsigned long mode = 0; > int size[3]; > int i; > >*************** >*** 373,379 **** > n = atoi(arg); > if (n < 1 || n > 12) { > warnx("console number out of range"); >! } else if (ioctl(0,VT_ACTIVATE,(char *)n) == -1) > warn("ioctl(VT_ACTIVATE)"); > } > >--- 373,379 ---- > n = atoi(arg); > if (n < 1 || n > 12) { > warnx("console number out of range"); >! } else if (ioctl(0, VT_ACTIVATE, (caddr_t) &n) == -1) > warn("ioctl(VT_ACTIVATE)"); > } > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message