From owner-freebsd-current@FreeBSD.ORG Tue Nov 19 17:51:05 2013 Return-Path: <owner-freebsd-current@FreeBSD.ORG> Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E65FA46E for <freebsd-current@freebsd.org>; Tue, 19 Nov 2013 17:51:05 +0000 (UTC) Received: from smtp.fgznet.ch (mail.fgznet.ch [81.92.96.47]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7CE172FFD for <freebsd-current@freebsd.org>; Tue, 19 Nov 2013 17:51:04 +0000 (UTC) Received: from deuterium.andreas.nets (dhclient-91-190-14-19.flashcable.ch [91.190.14.19]) by smtp.fgznet.ch (8.13.8/8.13.8/Submit_SMTPAUTH) with ESMTP id rAJHouLo050570; Tue, 19 Nov 2013 18:51:00 +0100 (CET) (envelope-from andreast-list@fgznet.ch) Message-ID: <528BA500.4050203@fgznet.ch> Date: Tue, 19 Nov 2013 18:50:56 +0100 From: Andreas Tobler <andreast-list@fgznet.ch> User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Konstantin Belousov <kostikbel@gmail.com> Subject: Re: WEAK_REFERENCE? References: <527EB428.6070104@FreeBSD.org> <20131111074706.GK59496@kib.kiev.ua> <5283ECA3.4080502@FreeBSD.org> <20131114060026.GH59496@kib.kiev.ua> <528A8E17.5090307@FreeBSD.org> <20131119072312.GW59496@kib.kiev.ua> In-Reply-To: <20131119072312.GW59496@kib.kiev.ua> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.64 on 81.92.96.47 Cc: Current <freebsd-current@freebsd.org>, brde@optusnet.com.au X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Discussions about the use of FreeBSD-current <freebsd-current.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/> List-Post: <mailto:freebsd-current@freebsd.org> List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, <mailto:freebsd-current-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 19 Nov 2013 17:51:06 -0000 On 19.11.13 08:23, Konstantin Belousov wrote: > On Mon, Nov 18, 2013 at 11:00:55PM +0100, Andreas Tobler wrote: >> I prepared two patches, see below. The amd64 one is reviewed by bde@ and >> the i386 is compile tested by me (runtime is theoretically also done, >> but I'm not sure since I do not have 32-bit apps on my amd64). > Use cc -m32. > >> >> The amd64 is compile and runtime tested. The tools, nm, shows that we >> have the weak_references as before. >> >> If you agree I'd like to commit both within a few days to -CURRENT. If >> someone steps up and confirms that the i386 part also runs, would be >> great, but I expect it to work. >> >> If I'm correct, there is some similar work to be done on arm, mips and >> sparc64, I'm happy to do this if the people like to have it done. But I >> do not own either of them to test in native config. Except sparc64..... >> Here I have blech ;) >> >> >> Here the two patches >> amd64: >> http://people.freebsd.org/~andreast/weak_ref_amd64.diff >> i386: >> http://people.freebsd.org/~andreast/weak_ref_i386.diff > > Amd64 patch is fine. For i386, I do not see a definition of the > WEAK_REFERENCE in the patch, and quick search of the pre-existing > definition in sys/i386 or lib/libc/i386 does not reveal anything. It's there now. Updated the diff. Thanks, Andreas