From owner-svn-src-all@FreeBSD.ORG Fri Feb 14 18:40:04 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BE3AA708; Fri, 14 Feb 2014 18:40:04 +0000 (UTC) Received: from mail-yk0-x22e.google.com (mail-yk0-x22e.google.com [IPv6:2607:f8b0:4002:c07::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3D0DA18A7; Fri, 14 Feb 2014 18:40:04 +0000 (UTC) Received: by mail-yk0-f174.google.com with SMTP id 20so24253889yks.5 for ; Fri, 14 Feb 2014 10:40:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=QEp/zjDAu1pIYBksu3K5o0Hl5t6RPofpsWwPGs3fgwI=; b=j6Rl8RD+91UQHDIibe1ZTVGSBQoPJbGFEbqqcNFDKIBaZAFlDIsvKJvHH98SUaWlR+ trHogFT0IcB+eXHkT+lwAH9BDIhV8lxqdTMc6kotqHmWBhsGcHsO3WGKbLxhTDqRiuT0 jAZK0Ea3Nk5W3Zr9pa4uRwfnw5avGdOLCXLxlNGRVNdmMfwAGCh6XbOdz4mgoW9X9+aK iPB8I95O2jbDuz6PfvTkZ2zXIgUZO88KN+tsqAnh+f3Ki9VEkimhbeli60BDYQc4nsiy pDjKaAsHmVmWBiqcYXPd7QhCQHWRhbigThhoOtDLX98AYX0YodlKsve4vCQyyXRCpJJE nPNw== X-Received: by 10.236.91.201 with SMTP id h49mr2548094yhf.96.1392403203427; Fri, 14 Feb 2014 10:40:03 -0800 (PST) Received: from [192.168.1.13] ([187.120.137.162]) by mx.google.com with ESMTPSA id h66sm19547391yhb.7.2014.02.14.10.39.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Feb 2014 10:40:02 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: svn commit: r261842 - in head/sys: conf dev/gpio From: Luiz Otavio O Souza In-Reply-To: <52FD321D.7010105@freebsd.org> Date: Fri, 14 Feb 2014 16:39:53 -0200 Content-Transfer-Encoding: quoted-printable Message-Id: <88E87461-9039-471F-9BE2-02742FB98282@gmail.com> References: <201402131708.s1DH8UJ7063297@svn.freebsd.org> <52FD321D.7010105@freebsd.org> To: Nathan Whitehorn X-Mailer: Apple Mail (2.1827) Cc: Luiz Otavio O Souza , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Feb 2014 18:40:04 -0000 On Feb 13, 2014, at 6:59 PM, Nathan Whitehorn = wrote: > On 02/13/14 11:08, Luiz Otavio O Souza wrote: >> Author: loos >> Date: Thu Feb 13 17:08:29 2014 >> New Revision: 261842 >> URL: http://svnweb.freebsd.org/changeset/base/261842 >>=20 >> Log: >> Add an OFW GPIO compatible bus. This allows the use of the DTS = files to >> describe GPIO bindings in the system. >> Move the GPIOBUS lock macros to gpiobusvar.h as they are now = shared between >> the OFW and the non OFW versions of GPIO bus. >> Export gpiobus_print_pins() so it can also be used on the OFW = GPIO bus. >> Approved by: adrian (mentor, implicit) >>=20 >> Added: >> head/sys/dev/gpio/ofw_gpiobus.c (contents, props changed) >> Modified: >> head/sys/conf/files >> head/sys/dev/gpio/gpiobus.c >> head/sys/dev/gpio/gpiobusvar.h >>=20 >>=20 >>=20 >> Added: head/sys/dev/gpio/ofw_gpiobus.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- /dev/null 00:00:00 1970 (empty, because file is newly = added) >> +++ head/sys/dev/gpio/ofw_gpiobus.c Thu Feb 13 17:08:29 2014 = (r261842) >> @@ -0,0 +1,338 @@ >> +/*- >> + * Copyright (c) 2009, Nathan Whitehorn >> + * Copyright (c) 2013, Luiz Otavio O Souza >> + * Copyright (c) 2013 The FreeBSD Foundation >> + * All rights reserved. >> + * >> + * Redistribution and use in source and binary forms, with or = without >> + * modification, are permitted provided that the following = conditions >> + * are met: >> + * 1. Redistributions of source code must retain the above copyright >> + * notice unmodified, this list of conditions, and the following >> + * disclaimer. >> + * 2. Redistributions in binary form must reproduce the above = copyright >> + * notice, this list of conditions and the following disclaimer = in the >> + * documentation and/or other materials provided with the = distribution. >> + * >> + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS = OR >> + * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED = WARRANTIES >> + * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE = DISCLAIMED. >> + * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, >> + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES = (INCLUDING, BUT >> + * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS = OF USE, >> + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON = ANY >> + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR = TORT >> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE = USE OF >> + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> + */ >> + >> +#include >> +__FBSDID("$FreeBSD$"); >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> +#include >> + >>=20 >=20 > is there a reason you include fdt_common.h here? Nothing here seems to = be FDT specific, rather than for Open Firmware generally. > -Nathan oops. It was used with fdt_is_enabled() to verify if the child device = was enabled, but it was removed in the last update of the code. This is = a leftover from this update. I=92ll check if it is okay to remove it and commit the fix. Thanks for point that out. Luiz=