From owner-cvs-all@FreeBSD.ORG Fri Mar 7 01:39:53 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 609451065675; Fri, 7 Mar 2008 01:39:53 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail15.syd.optusnet.com.au (mail15.syd.optusnet.com.au [211.29.132.196]) by mx1.freebsd.org (Postfix) with ESMTP id D52C58FC21; Fri, 7 Mar 2008 01:39:52 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c220-239-252-11.carlnfd3.nsw.optusnet.com.au (c220-239-252-11.carlnfd3.nsw.optusnet.com.au [220.239.252.11]) by mail15.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id m271dmxU032382 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 7 Mar 2008 12:39:49 +1100 Date: Fri, 7 Mar 2008 12:39:48 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Mike Silbersack In-Reply-To: <20080305230954.X55190@odysseus.silby.com> Message-ID: <20080307122252.Y11033@delplex.bde.org> References: <200803051121.m25BLE03035426@repoman.freebsd.org> <20080305230954.X55190@odysseus.silby.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Bruce Evans , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/include _types.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 01:39:53 -0000 On Wed, 5 Mar 2008, Mike Silbersack wrote: > On Wed, 5 Mar 2008, Bruce Evans wrote: >> Change float_t and double_t to long double on i386. All floating point > > For those of us who are not floating point experts, can you explain a few > things? Other points replied to separately. > As I've said in the past, I'd really, really, really like to see regression > tests for any change to the floating point functions. The types of changes > you've been making are not easy to verify just by looking at diffs. I run local regression tests of 4 billon to 64 billion cases per function or 1.3 trillion cases for 125 functions a 36-hour run on a 2.2HGz UP system. These are not well organized enough for commit. You will have to trust that they are done before commit (or after on some other machines) :-). I mostly use semi-exhaustive (exhaustive for 1-arg float precision functions) checks on machine-generated args. This seems to find problems more routinely than smarter tests, up to at least double precision. das@ committed some smarter tests. OTOH, I barely tested the changes to float_t and double_t. These types are so rarely used that they are never used in /usr/src, at least in my old src tree, except for my uncommitted changes in libm parts. Bruce