From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Apr 25 13:30:04 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C52A31065675; Sat, 25 Apr 2009 13:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A153B8FC1F; Sat, 25 Apr 2009 13:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n3PDU4k7034846; Sat, 25 Apr 2009 13:30:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n3PDU4fR034845; Sat, 25 Apr 2009 13:30:04 GMT (envelope-from gnats) Resent-Date: Sat, 25 Apr 2009 13:30:04 GMT Resent-Message-Id: <200904251330.n3PDU4fR034845@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@freebsd.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Cc: marcus@freebsd.org Resent-Reply-To: FreeBSD-gnats-submit@freebsd.org, Eygene Ryabinkin Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3EF71106564A for ; Sat, 25 Apr 2009 13:28:23 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45]) by mx1.freebsd.org (Postfix) with ESMTP id E69FD8FC1A for ; Sat, 25 Apr 2009 13:28:22 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from amnesiac.at.no.dns (ppp85-141-163-213.pppoe.mtu-net.ru [85.141.163.213]) by 0.mx.codelabs.ru with esmtps (TLSv1:CAMELLIA256-SHA:256) id 1LxhvZ-000NQB-PG for FreeBSD-gnats-submit@freebsd.org; Sat, 25 Apr 2009 17:28:21 +0400 Message-Id: <20090425132821.193C917112@amnesiac.at.no.dns> Date: Sat, 25 Apr 2009 17:28:21 +0400 (MSD) From: Eygene Ryabinkin To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 X-GNATS-Notify: marcus@freebsd.org Cc: Subject: ports/134000: [patch] ports-mgmt/portling: disable Perl warning for the case of empty PKGINSTALLVER X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Eygene Ryabinkin List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Apr 2009 13:30:05 -0000 >Number: 134000 >Category: ports >Synopsis: [patch] ports-mgmt/portling: disable Perl warning for the case of empty PKGINSTALLVER >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Apr 25 13:30:04 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Eygene Ryabinkin >Release: FreeBSD 7.2-PRERELEASE amd64 >Organization: Code Labs >Environment: System: FreeBSD 7.2-PRERELEASE amd64 >Description: For the ports with empty PKGINSTALLVER and defined CONFLICTS portlint produces Perl warning: ----- Argument "" isn't numeric in numeric ge (>=) at /usr/local/bin/portlint line 2378. ----- >How-To-Repeat: Invoke portlint, e.g. for x11-drivers/xf86-input-synaptics. >Fix: The following patch will correct the things. Possibly, PORTREVISION should be bumped to delived the fixed port to all users who perform regular upgrades. --- portlint-chase-empty-PKGINSTALLVER.diff begins here --- >From a3bb60ea0afadd0199bf59b5e2d943853a3edefc Mon Sep 17 00:00:00 2001 From: Eygene Ryabinkin Date: Sat, 25 Apr 2009 17:13:19 +0400 When the port lacks variable PKGINSTALLVER and has CONFLICTS, portlint invocation will spit Perl warning, ----- Argument "" isn't numeric in numeric ge (>=) at /usr/local/bin/portlint line 2378. ----- This patch adds a simple check for variable presence. Signed-off-by: Eygene Ryabinkin --- ports-mgmt/portlint/src/portlint.pl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ports-mgmt/portlint/src/portlint.pl b/ports-mgmt/portlint/src/portlint.pl index 20ccaf5..1aa8741 100644 --- a/ports-mgmt/portlint/src/portlint.pl +++ b/ports-mgmt/portlint/src/portlint.pl @@ -2375,7 +2375,8 @@ DIST_SUBDIR EXTRACT_ONLY print "OK: checking CONFLICTS.\n" if ($verbose); foreach my $conflict (split ' ', $makevar{CONFLICTS}) { my $selfconflict; - if ($makevar{PKGINSTALLVER} >= 20040125) { + if (length($makevar{PKGINSTALLVER}) && + $makevar{PKGINSTALLVER} >= 20040125) { $selfconflict = !system($pkg_version, '-T', $makevar{PKGNAME}, $conflict); } else { -- 1.6.2.4 --- portlint-chase-empty-PKGINSTALLVER.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: