From owner-cvs-all  Wed Feb 19 14: 7:47 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 42C6D37B401; Wed, 19 Feb 2003 14:07:44 -0800 (PST)
Received: from out3.mx.nwbl.wi.voyager.net (out3.mx.nwbl.wi.voyager.net [169.207.3.121])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 08D3343F75; Wed, 19 Feb 2003 14:07:44 -0800 (PST)
	(envelope-from silby@silby.com)
Received: from [10.1.1.6] (d146.as8.nwbl0.wi.voyager.net [169.207.133.148])
	by out3.mx.nwbl.wi.voyager.net (Postfix) with ESMTP
	id 398D977E21; Wed, 19 Feb 2003 16:07:18 -0600 (CST)
Date: Wed, 19 Feb 2003 16:16:18 -0600 (CST)
From: Mike Silbersack <silby@silby.com>
To: Scott Long <scottl@FreeBSD.org>
Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/aac aac.c aac_pci.c
In-Reply-To: <200302192158.h1JLwYJn025529@repoman.freebsd.org>
Message-ID: <20030219161458.T62705@patrocles.silby.com>
References: <200302192158.h1JLwYJn025529@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


Out of curiosity, how are you testing MPSAFEness other than by visual
inspection?  I've been pondering making if_vr and if_xl MPSAFE, but I
really have no clue how to verify that I've done the job correctly.

Mike "Silby" Silbersack


On Wed, 19 Feb 2003, Scott Long wrote:

> scottl      2003/02/19 13:58:34 PST
>
>   Modified files:
>     sys/dev/aac          aac.c aac_pci.c
>   Log:
>   Make the aac driver be INTR_MPSAFE.  Once the interrupt handler determines
>   that a command completion happened, all further processing is deferred to
>   a taskqueue.  The taskqueue itself runs implicetely under Giant, but we
>   already used a taskqueue for the biodone() processing, so this at least
>   saves the contesting of Giant in the interrupt handler.
>
>   Revision  Changes    Path
>   1.54      +12 -36    src/sys/dev/aac/aac.c
>   1.29      +3 -2      src/sys/dev/aac/aac_pci.c
>

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message