Date: Tue, 21 Aug 2018 21:34:42 +0200 From: Kurt Jaeger <pi@freebsd.org> To: Yuri <yuri@rawbw.com> Cc: Kurt Jaeger <pi@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r477695 - in head/graphics: . libheif Message-ID: <20180821193442.GN1673@fc.opsec.eu> In-Reply-To: <b4a250d0-7fe5-5830-d1d0-d93f3736471f@rawbw.com> References: <201808210024.w7L0OIQH031059@repo.freebsd.org> <b4a250d0-7fe5-5830-d1d0-d93f3736471f@rawbw.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi! > On 8/20/18 5:24 PM, Kurt Jaeger wrote: > > +BROKEN_FreeBSD_10= encoder_fuzzer.cc:84:5: error: use of undeclared identifier 'free' > > This is most likely wrong. 'free' is available everywhere. The likely > reason is a missing #include <stdlib.h> somewhere. Yes, it was wrong. Thanks for the pointer, fixed. > > +LIB_DEPENDS= libde265.so:multimedia/libde265 > > +LIB_DEPENDS+= libx265.so:multimedia/x265 > > +LIB_DEPENDS+= libpng16.so:graphics/png > These are usually defined without repeating LIB_DEPENDS+=. Fixed. > > +USES= autoreconf libtool pkgconfig shared-mime-info \ > > + shebangfix > > +USE_GITHUB= yes > > +GH_ACCOUNT= strukturag > > +GH_PROJECT= libheif > > + > > +GNU_CONFIGURE= yes > > + > > +SHEBANG_GLOB= *.sh > > + > > +USE_LDCONFIG= yes > > USE_LDCONFIG should definitely be in the USExx section. GNU_CONFIGURE and SHEBANG_GLOB should also probably be in USExx section, because this way Makefile looks more compact. Done as you described. -- pi@FreeBSD.org +49 171 3101372 2 years to go !
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180821193442.GN1673>