From owner-cvs-all@FreeBSD.ORG Sat Dec 4 19:38:21 2010 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CFB791065670 for ; Sat, 4 Dec 2010 19:38:21 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 657258FC0C for ; Sat, 4 Dec 2010 19:38:20 +0000 (UTC) Received: from outgoing.leidinger.net (p57B3A02D.dip.t-dialin.net [87.179.160.45]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 1C664844012; Sat, 4 Dec 2010 20:38:12 +0100 (CET) Received: from unknown (IO.Leidinger.net [192.168.2.110]) by outgoing.leidinger.net (Postfix) with ESMTP id 80FEB14F4; Sat, 4 Dec 2010 20:38:08 +0100 (CET) Date: Sat, 4 Dec 2010 20:38:05 +0100 From: Alexander Leidinger To: Benedict Reuschling Message-ID: <20101204203805.00006179@unknown> In-Reply-To: <201012041756.oB4HuFjD001878@repoman.freebsd.org> References: <201012041756.oB4HuFjD001878@repoman.freebsd.org> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.16.0; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 1C664844012.A3E89 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1, required 6, autolearn=disabled, ALL_TRUSTED -1.00) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1292096296.91661@Ley3gZNwdEOmrg49/EC73A X-EBL-Spam-Status: No Cc: doc-committers@FreeBSD.org, mexas@bristol.ac.uk, cvs-doc@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/handbook/cutting-edge chapter.sgml X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Dec 2010 19:38:21 -0000 On Sat, 4 Dec 2010 17:56:15 +0000 (UTC) Benedict Reuschling wrote: > bcr 2010-12-04 17:56:15 UTC > > FreeBSD doc repository > > Modified files: > en_US.ISO8859-1/books/handbook/cutting-edge chapter.sgml > Log: > Add a section about deleting old files, directories and libraries > with a short description why this is necessary. Pointy hat to: netchild (for not doing something like this when he implemented this). Improvement suggestions: - While this is already covered in "implemented elsewhere": Changing the version number of a library can also be a reason. Strictly speaking this is "elsewhere", from another point of strict-view this is not elsewhere but in the the same library, just another version. - There is not only the argument of storage space, but also security (if an old lib-version is used which may contain a security hole or not), and stability (old lib version may have a little bit different behavior, or may cause crashes if mixed with more recently compiled stuff which includes a reference to a more recent version of the same lib). This is mentioned at the end of the description, but IMHO it would be better to describe this in the beginning. - check-old includes check-old-libs, no need to run both. - I suggest to delete the files after a mergemaster was done, and not directly after the installworld. This way an outdated rc- script can not reference something which gets deleted. - Running delete-old-libs blindly is not a good idea. Before the delete-old-libs there should be a check if something references those libs (e.g. with sysutils/libchk), and if yes, the ports/programs/libs should be recompiled before the delete-old-libs target is executed. It is mentioned at the end that you shouldn't remove files/libs which are still used, but IMHO it would be better to mention it before telling to do delete-old(-libs). - BATCH_DELETE_OLD_FILES does not need to be an env-var, as a make-var it works too: "make -DBATCH_DELETE_OLD_LIBS delete-old" - As portmaster is mentioned, I suggest to mention portupgrade too. Bye, Alexander.