From owner-freebsd-smp Tue Apr 24 3:37:40 2001 Delivered-To: freebsd-smp@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id A03D937B422 for ; Tue, 24 Apr 2001 03:37:35 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id UAA21195; Tue, 24 Apr 2001 20:37:16 +1000 Date: Tue, 24 Apr 2001 20:34:27 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Mark Murray Cc: smp@FreeBSD.ORG Subject: Re: Kernel include file cleanup take #3. In-Reply-To: <200104230602.f3N62Tw49163@gratis.grondar.za> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Mon, 23 Apr 2001, Mark Murray wrote: > > > http://people.freebsd.org/~markm/patches/sys.SYS_MUTEX.diff.1 > > You actually made a subinclude of > > other headers that need it, and one that doesn't ( doesn't > > need it directly, but it includes which does). > > OK. Removed it (plus some other junk) from eventhandler. From conf? > > Please change the copyright owner to yourself. FreeBSD, Inc. still > > doesn't exist in a form suitable for holding copyrights. > > OK. Done. For such small files I'd prefer them to be owned by the project, > but I don't care enough to be religious about it. Actually, the copyrights from the original files would be better. > > I'm not sure if the names for the new types headers are right. Perhaps > > they should have a leading underscore to inhibit direct inclusion, or > > not have the "_types" suffix, to make them less verbose and not hint > > that they are limited to types. > > How about _mutex.h and _lock.h? OK. The pfind() changes gave about another .c files that need but don't include it. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message