From owner-cvs-all  Sun Sep 16 19:51:53 2001
Delivered-To: cvs-all@freebsd.org
Received: from polaris.hitachi-to.co.jp (regulus.hitachi-to.co.jp [210.130.175.6])
	by hub.freebsd.org (Postfix) with ESMTP
	id F071637B409; Sun, 16 Sep 2001 19:51:39 -0700 (PDT)
Date: Mon, 17 Sep 2001 11:51:13 +0900 (JST)
Message-Id: <20010917.115113.07647289.iwasaki@jp.FreeBSD.org>
To: msmith@FreeBSD.org
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/acpica acpi.c
From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
In-Reply-To: <200109150414.f8F4EVA81504@freefall.freebsd.org>
References: <200109150414.f8F4EVA81504@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Hi, mike.

> msmith      2001/09/14 21:14:31 PDT
> 
>   Modified files:
>     sys/dev/acpica       acpi.c 
>   Log:
>   Disable devices that are not present; at a later stage we can then enable
>   them if the device arrives.
>   
>   This should solve the problem where devices that have been disabled eg. in
>   the BIOS show up with nonsense resources and hang the bootstrap process.
>   
>   Revision  Changes    Path
>   1.39      +11 -1     src/sys/dev/acpica/acpi.c

It seems that this change breaks non-ACPI_TYPE_DEVICE device probing
such as acpi_tz (see nsxfname.c:AcpiGetObjectInfo()).
How about the following patch?
# or we need to fix acpi_DeviceIsPresent()

Index: acpi.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/acpica/acpi.c,v
retrieving revision 1.39
diff -u -r1.39 acpi.c
--- acpi.c	15 Sep 2001 04:14:31 -0000	1.39
+++ acpi.c	17 Sep 2001 02:14:22 -0000
@@ -790,7 +790,7 @@
 	     * leave it disabled (so that we have a device_t attached to
 	     * the handle, but we don't probe it).
 	     */
-	    if (!acpi_DeviceIsPresent(child)) {
+	    if ((type == ACPI_TYPE_DEVICE) && (!acpi_DeviceIsPresent(child))) {
 		device_disable(child);
 		break;
 	    }


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message