From owner-freebsd-gnome Mon Apr 15 19:55:38 2002 Delivered-To: freebsd-gnome@freebsd.org Received: from gyros.marcuscom.com (rdu57-17-158.nc.rr.com [66.57.17.158]) by hub.freebsd.org (Postfix) with ESMTP id 126D637B405; Mon, 15 Apr 2002 19:55:33 -0700 (PDT) Received: from gyros.marcuscom.com (localhost [127.0.0.1]) by gyros.marcuscom.com (8.12.2/8.12.2) with ESMTP id g3G2tKpb006706; Mon, 15 Apr 2002 22:55:21 -0400 (EDT) (envelope-from marcus@marcuscom.com) Received: (from marcus@localhost) by gyros.marcuscom.com (8.12.2/8.12.2/Submit) id g3G2tKBJ006705; Mon, 15 Apr 2002 22:55:20 -0400 (EDT) X-Authentication-Warning: gyros.marcuscom.com: marcus set sender to marcus@marcuscom.com using -f Subject: gnomemedia patches From: Joe Marcus Clarke To: Arne H Juul Cc: sobomax@freebsd.org, gnome@freebsd.org In-Reply-To: References: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-32V/igNWHF+ZdW2nyU9+" X-Mailer: Ximian Evolution 1.0.3 Date: 15 Apr 2002 23:55:20 -0300 Message-Id: <1018925720.302.16.camel@gyros.marcuscom.com> Mime-Version: 1.0 Sender: owner-freebsd-gnome@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --=-32V/igNWHF+ZdW2nyU9+ Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2002-04-15 at 20:49, Arne H Juul wrote: > To get the Gnome CD player application (gtcd) to > play nicely on my FreeBSD 4.5 system and send > updates to freedb.org I had to make a couple of patches > to gnome-media-1.2.3. >=20 > The first i'm not completely sure of - it tried to access > /usr/X11R6/share/gnome/gnome/cddb-submit-methods instead > of /usr/X11R6/share/gnome/cddb-submit-methods but of course > the fix may be in the wrong place; I think it's needed > only because of the existing FreeBSD patches/configure > machinery that forces $(datadir) to /usr/X11R6/share/gnome > while the gnome files want to use $(datadir)/gnome instead. > So the "right" fix may be to configure with --datadir > /usr/X11R6/share and revert these FreeBSD specific patches > for all I know. This looks good to me. >=20 > The second fix (make sure we have the device open to do the ioctl) > is copied from the similar linux case so I'm pretty sure it's right > (or at least, better than the previous version) so it doesn't read > the volume as 0 all the time. This also seems reasonable. Maxim, what do you think? Joe >=20 [snip] --=20 PGP Key: http://www.marcuscom.com/pgp.asc --=-32V/igNWHF+ZdW2nyU9+ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEABECAAYFAjy7kpgACgkQb2iPiv4Uz4eD+ACgn0KsFeTPuqyvpHr3/xKYfY81 Kd0An0SpGyV+HzYYY8fbyIohLqgb5UVE =sCK3 -----END PGP SIGNATURE----- --=-32V/igNWHF+ZdW2nyU9+-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-gnome" in the body of the message