From owner-freebsd-fs@FreeBSD.ORG Thu Jul 12 09:16:04 2007 Return-Path: X-Original-To: fs@freebsd.org Delivered-To: freebsd-fs@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 117A716A41F; Thu, 12 Jul 2007 09:16:04 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail14.syd.optusnet.com.au (mail14.syd.optusnet.com.au [211.29.132.195]) by mx1.freebsd.org (Postfix) with ESMTP id 8DA9813C455; Thu, 12 Jul 2007 09:16:03 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c220-239-235-248.carlnfd3.nsw.optusnet.com.au (c220-239-235-248.carlnfd3.nsw.optusnet.com.au [220.239.235.248]) by mail14.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id l6C9FvQr013643 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 12 Jul 2007 19:16:00 +1000 Date: Thu, 12 Jul 2007 19:15:57 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Brian Chu In-Reply-To: <47a4f3080707111944u2b9ad091t2f4b8be482ab3a69@mail.gmail.com> Message-ID: <20070712185224.I4682@delplex.bde.org> References: <20070710233455.O2101@besplex.bde.org> <47a4f3080707111944u2b9ad091t2f4b8be482ab3a69@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: bugs@freebsd.org, fs@freebsd.org Subject: Re: msdosfs not MPSAFE X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2007 09:16:04 -0000 On Wed, 11 Jul 2007, Brian Chu wrote: > I've already planned to look at this. I had not been aware that calls > to the Giant Lock were being ignored in the current kernel. Maybe the problem doesn't affect -current. I first saw this bug in a 3-year old version of -current and thought that I verified that it still affects -current. In the old version, getdirentries() and stat() are Giant-locked (not MSTD in syscalls.master), so I don't understand why there was a problem. In -current, msdosfs is not MNTK_MPSAFE, so the problem shouldn't affect -current -- it is already fixed unbetter by Giant-locking everything. [context lost to top posting] Bruce