From owner-freebsd-bugs@FreeBSD.ORG  Sat Feb 16 06:10:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 9274A653
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Sat, 16 Feb 2013 06:10:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 82507B2D
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Sat, 16 Feb 2013 06:10:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r1G6A1AT097426
 for <freebsd-bugs@freefall.freebsd.org>; Sat, 16 Feb 2013 06:10:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r1G6A1Qh097425;
 Sat, 16 Feb 2013 06:10:01 GMT (envelope-from gnats)
Date: Sat, 16 Feb 2013 06:10:01 GMT
Message-Id: <201302160610.r1G6A1Qh097425@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: kern/175674: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Feb 2013 06:10:01 -0000

The following reply was made to PR kern/175674; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/175674: commit references a PR
Date: Sat, 16 Feb 2013 06:07:16 +0000 (UTC)

 Author: davidxu
 Date: Sat Feb 16 06:07:07 2013
 New Revision: 246872
 URL: http://svnweb.freebsd.org/changeset/base/246872
 
 Log:
   Simplify code by using flag O_EXLOCK.
   
   PR: kern/175674
 
 Modified:
   head/lib/libc/gen/sem_new.c
 
 Modified: head/lib/libc/gen/sem_new.c
 ==============================================================================
 --- head/lib/libc/gen/sem_new.c	Sat Feb 16 05:22:48 2013	(r246871)
 +++ head/lib/libc/gen/sem_new.c	Sat Feb 16 06:07:07 2013	(r246872)
 @@ -198,15 +198,11 @@ _sem_open(const char *name, int flags, .
  		goto error;
  	}
  
 -	fd = _open(path, flags|O_RDWR|O_CLOEXEC, mode);
 +	fd = _open(path, flags|O_RDWR|O_CLOEXEC|O_EXLOCK, mode);
  	if (fd == -1)
  		goto error;
 -	if (flock(fd, LOCK_EX) == -1)
 +	if (_fstat(fd, &sb))
  		goto error;
 -	if (_fstat(fd, &sb)) {
 -		flock(fd, LOCK_UN);
 -		goto error;
 -	}
  	if (sb.st_size < sizeof(sem_t)) {
  		sem_t tmp;
  
 @@ -214,10 +210,8 @@ _sem_open(const char *name, int flags, .
  		tmp._kern._has_waiters = 0;
  		tmp._kern._count = value;
  		tmp._kern._flags = USYNC_PROCESS_SHARED | SEM_NAMED;
 -		if (_write(fd, &tmp, sizeof(tmp)) != sizeof(tmp)) {
 -			flock(fd, LOCK_UN);
 +		if (_write(fd, &tmp, sizeof(tmp)) != sizeof(tmp))
  			goto error;
 -		}
  	}
  	flock(fd, LOCK_UN);
  	sem = (sem_t *)mmap(NULL, sizeof(sem_t), PROT_READ|PROT_WRITE,
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"