Date: Wed, 18 May 2016 17:19:15 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r415434 - head/devel/fb-adb Message-ID: <7C82BC6DAE487C18A84E8A19@ogg.in.absolight.net> In-Reply-To: <1t4z-v1uf-wny@vfemail.net> References: <201605181156.u4IBuseK058800@repo.freebsd.org> <1t4z-v1uf-wny@vfemail.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========B97BE8BFD3A01D443D4E==========
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
+--On 18 mai 2016 17:10:32 +0200 Jan Beich <jbeich@FreeBSD.org> wrote:
|> .else
|> -NDK_DISTFILES= ${DISTNAME_ndk}.bin:ndk,p7zip
|> +NDK_DISTFILES= ${DISTNAME_ndk}.bin:ndk
|> DISTNAME_ndk= android-ndk-r10e-linux-${LINUX_RPM_ARCH:C/i.86/x86/}
|> WRKSRC_ndk= ${WRKDIR}/${DISTNAME_ndk:C/(-[^-]+){2}$//}
|> .endif
|
| I disagree with the fix. Either put :p7zip in MASTER_SITES as well or
| use EXTRACT_ONLY{,_7z} directly. LINUX_RPM_ARCH=x86_64 distfile fails to
| extract with bsdtar(1), so :p7zip group limits USES=7z:partial,p7zip to
| the specific file. For details, see do-p7zip-extract implementation.
The p7zip MASTER_SITES group does not exist. It is going to be an error
soon.
I see now that this port, and USES=7z are abusing the fact that nonexistant
groups are just overlooked right now.
This port should better be using the EXTRACT_ONLY_7z variable for that.
--
Mathieu Arnold
--==========B97BE8BFD3A01D443D4E==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJXPIfzXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IVecP/0iX/aQwnItqi4L/wCqjD17t
oC8R8Ya9wbECXHSyLvVXgdyWpeXdUT+E7Rj2Cvg+Xe0OQMrQaCJ4pGUgYhzgM/nW
HIHzJFVtLbMPw13O+gIvbv8kbDuX9io+2Ht/CdB0GZRl5rMZ5l6F+R5GsXswYR9d
m/JLKRwUYBpnekFsycEBsL3IC+fIEnpwFU6CgUpLCpb7pwVIms1z9Lu5h8ujN0AF
UUgPjKw4uuuR9jVi0lK1u1x4VcLOlWdBNSDiCAXiZ46V7JGnlTJrs+1QiIuS4zW0
rwXHLf7jXH2l9eVovZgNw6kFbr0TPh0qNhH4PlLbZHcne35ZRWan9SAO4yoBpRQo
7N+3Ob+1RoeIAPLHIZTrRdXDyC5ukxzK809Y1TRoF8Wsft88hPLkTtliTct7bIOM
DI+DSmvfmsswhh6GH313EQ/uRKMcLFUH3GBf6sNY2b4Ztxts8/gk9aocgjvfBICN
/ClArmJIt+xSGpNdFcex6ZzDmEdikX1aJlL1C/EtPoPvfrgRXXWUGoGok2FBsY9u
Vd2xeoCr3qaq5vjVe+tqr57EkGdAsBdHJ8AvH/w4g2N6alLOoMVqBN9sPHL85RDu
uoofGlpKbfUTb8LaKYe9ziVxXC01cRVuS9ph5dmScIzn1JVIVlj7ZXVOD53UTxfn
MDueQHaj8+cUOMgpoEmm
=ABb3
-----END PGP SIGNATURE-----
--==========B97BE8BFD3A01D443D4E==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7C82BC6DAE487C18A84E8A19>