Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 May 2019 11:07:42 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r347320 - head/sys/dev/mlx5/mlx5_en
Message-ID:  <201905081107.x48B7gpB063935@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Wed May  8 11:07:42 2019
New Revision: 347320
URL: https://svnweb.freebsd.org/changeset/base/347320

Log:
  Make sure the flow destination structure does not use values off the stack
  in mlx5en(4).
  
  MFC after:	3 days
  Sponsored by:	Mellanox Technologies

Modified:
  head/sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c

Modified: head/sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c
==============================================================================
--- head/sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c	Wed May  8 11:07:20 2019	(r347319)
+++ head/sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c	Wed May  8 11:07:42 2019	(r347320)
@@ -227,7 +227,7 @@ mlx5e_add_eth_addr_rule_sub(struct mlx5e_priv *priv,
     struct mlx5e_eth_addr_info *ai, int type,
     u32 *mc, u32 *mv)
 {
-	struct mlx5_flow_destination dest;
+	struct mlx5_flow_destination dest = {};
 	u8 mc_enable = 0;
 	struct mlx5_flow_rule **rule_p;
 	struct mlx5_flow_table *ft = priv->fts.main.t;
@@ -507,7 +507,7 @@ mlx5e_add_vlan_rule_sub(struct mlx5e_priv *priv,
     u32 *mc, u32 *mv)
 {
 	struct mlx5_flow_table *ft = priv->fts.vlan.t;
-	struct mlx5_flow_destination dest;
+	struct mlx5_flow_destination dest = {};
 	u8 mc_enable = 0;
 	struct mlx5_flow_rule **rule_p;
 	int err = 0;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905081107.x48B7gpB063935>