From owner-freebsd-mobile  Tue Sep  4 12:25: 9 2001
Delivered-To: freebsd-mobile@freebsd.org
Received: from ns.yogotech.com (ns.yogotech.com [206.127.123.66])
	by hub.freebsd.org (Postfix) with ESMTP id 7766D37B405
	for <freebsd-mobile@FreeBSD.ORG>; Tue,  4 Sep 2001 12:25:01 -0700 (PDT)
Received: from nomad.yogotech.com (nomad.yogotech.com [206.127.123.131])
	by ns.yogotech.com (8.9.3/8.9.3) with ESMTP id NAA08249;
	Tue, 4 Sep 2001 13:24:59 -0600 (MDT)
	(envelope-from nate@nomad.yogotech.com)
Received: (from nate@localhost)
	by nomad.yogotech.com (8.8.8/8.8.8) id NAA09844;
	Tue, 4 Sep 2001 13:24:58 -0600 (MDT)
	(envelope-from nate)
From: Nate Williams <nate@yogotech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15253.10889.977127.513674@nomad.yogotech.com>
Date: Tue, 4 Sep 2001 13:24:57 -0600
To: Toshihiko ARAI <toshi@jp.FreeBSD.org>
Cc: freebsd-mobile@FreeBSD.ORG
Subject: Re: [PATCH] pccard_ether and removable_* variables
In-Reply-To: <200109011153.f81BrZL93078.toshi@jp.FreeBSD.org>
References: <15245.13394.275183.61715@nomad.yogotech.com>
	<200109011153.f81BrZL93078.toshi@jp.FreeBSD.org>
X-Mailer: VM 6.95 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid
Reply-To: nate@yogotech.com (Nate Williams)
Sender: owner-freebsd-mobile@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-mobile.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-mobile>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-mobile>
X-Loop: FreeBSD.org

> I ask for a review of the following patches.
> 
> A summary of a patch,
> 
> * Delete removable_interfaces and pccard_ifconfig.  However,
>   pccard_ifconfig is kept for compatibility in pccard_ether.
> * Documentation of removable_route_flush and static_routes_<interface>.
> * Modification of sysinstall, deleted a pccard_ifconfig, added
>   some entry to a menu, and some corrections.
> 
> http://home.jp.FreeBSD.org/~toshi/pccard-current-20010901.diff

What's the purpose of the following lines of code:


        # Clean the routing table
        case ${removable_route_flush} in
-       [Nn][Oo])
+       [Nn][Oo] | '')
                ;;
        *)      
-               # flush beforehand, just in case....
-               route -n flush -inet
+               case ${gateway_enable} in
+               [Yy][Ee][Ss])
+                       ;;
+               *)
+                       route -n flush -inet
+                       ;;
+               esac
                ;;
        esac
        ;;

In particular, why don't we flush the routing table if gateway_enable is
set?  That's seems counter-productive.

Also, as I've mentioned before, is there anyway we can have the routes
added via 'static_routes_<interface>' flushed when the interface is
removed?  This seems to be a step in the right direction, and may
obviate the need for removable_route_flush completely.



Nate

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message