From owner-freebsd-net@FreeBSD.ORG  Fri Mar  4 16:08:09 2005
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E268416A4CE
	for <net@freebsd.org>; Fri,  4 Mar 2005 16:08:09 +0000 (GMT)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A8A4643D1F
	for <net@freebsd.org>; Fri,  4 Mar 2005 16:08:09 +0000 (GMT)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.11/8.12.8) with ESMTP id j24G89RH004247;
	Fri, 4 Mar 2005 08:08:09 -0800 (PST)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.11/8.12.3/Submit) id j24G89J8004246;
	Fri, 4 Mar 2005 08:08:09 -0800 (PST)
	(envelope-from rizzo)
Date: Fri, 4 Mar 2005 08:08:09 -0800
From: Luigi Rizzo <rizzo@icir.org>
To: dima <_pppp@mail.ru>
Message-ID: <20050304080809.A4180@xorpc.icir.org>
References: <20050304025942.E134@xorpc.icir.org>
	<E1D7Cv5-0004mV-00._pppp-mail-ru@f22.mail.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <E1D7Cv5-0004mV-00._pppp-mail-ru@f22.mail.ru>;
	from _pppp@mail.ru on Fri, Mar 04, 2005 at 04:32:43PM +0300
cc: net@freebsd.org
Subject: Re: Polling objectives (was Re: Giant-free polling [PATCH])
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Mar 2005 16:08:10 -0000

On Fri, Mar 04, 2005 at 04:32:43PM +0300, dima wrote:
...
> PS: my question about locking in ether_poll_register() is still actual. I think pr[] should be protected by sx while adding a new handler.

ether_poll_register() was called by *foo_intr() so in 4.x it was protected
by splimp() or Giant. It is likely that now, with drivers being
no more under a single lock, you need to protect it as well with
a private lock.

cheers
luigi