From owner-svn-ports-head@FreeBSD.ORG Thu Apr 16 02:12:56 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 3D4D1432; Thu, 16 Apr 2015 02:12:56 +0000 (UTC) Date: Thu, 16 Apr 2015 02:12:56 +0000 From: Alexey Dokuchaev To: Bryan Drewery Cc: Dmitry Marakasov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r383191 - head/Mk Message-ID: <20150416021256.GB96530@FreeBSD.org> References: <20150408232144.GX21982@hades.panopticon> <5525D48E.5090305@FreeBSD.org> <20150409110221.GB45809@hades.panopticon> <55269785.7030307@FreeBSD.org> <20150409153856.GA31951@FreeBSD.org> <55269FE4.2030208@FreeBSD.org> <20150409160330.GB31951@FreeBSD.org> <5526A52E.4090801@FreeBSD.org> <20150409162416.GA54797@FreeBSD.org> <552E8E99.1050309@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <552E8E99.1050309@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 02:12:56 -0000 On Wed, Apr 15, 2015 at 11:15:21AM -0500, Bryan Drewery wrote: > On 4/9/2015 11:24 AM, Alexey Dokuchaev wrote: > > On Thu, Apr 09, 2015 at 11:13:34AM -0500, Bryan Drewery wrote: > >> I understand what you're trying to do and I agree it would be useful if > >> it worked. Validating port logic (such as whether EXTRA_PATCHES has > >> something) based on OSVERSION is very useful. I'll think about how to > >> fix it. > > > > Right, EXTRA_PATCHES is a very good example. Good to know that there is > > mutual understanding now and a chance for a fix. :) Thanks, > > Fixed in r384060. > > You can now specify it on the cmdline. make -V BLAH OSVERSION=blah. If > it is in env or make.conf it will still error. Nice; all my previous testing tricks work fine again, thank you Bryan! ./danfe