From owner-p4-projects@FreeBSD.ORG Thu May 1 09:11:39 2003 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id CF3B937B404; Thu, 1 May 2003 09:11:38 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 703BE37B401 for ; Thu, 1 May 2003 09:11:38 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1686E43FA3 for ; Thu, 1 May 2003 09:11:38 -0700 (PDT) (envelope-from des@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h41GBb0U068529 for ; Thu, 1 May 2003 09:11:37 -0700 (PDT) (envelope-from des@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h41GBbq4068524 for perforce@freebsd.org; Thu, 1 May 2003 09:11:37 -0700 (PDT) Date: Thu, 1 May 2003 09:11:37 -0700 (PDT) Message-Id: <200305011611.h41GBbq4068524@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to des@freebsd.org using -f From: Dag-Erling Smorgrav To: Perforce Change Reviews Subject: PERFORCE change 30311 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 May 2003 16:11:39 -0000 http://perforce.freebsd.org/chv.cgi?CH=30311 Change 30311 by des@des.at.des.thinksec.com on 2003/05/01 09:11:15 Some compilers (gcc at least) promote the integer literal 0x80000000 to long, while enums are required to fit in an int. To avoid the warning this causes, use (-0x7fffffff - 1) instead of 0x80000000. Affected files ... .. //depot/projects/openpam/include/security/pam_constants.h#20 edit Differences ... ==== //depot/projects/openpam/include/security/pam_constants.h#20 (text+ko) ==== @@ -31,7 +31,7 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * $P4: //depot/projects/openpam/include/security/pam_constants.h#19 $ + * $P4: //depot/projects/openpam/include/security/pam_constants.h#20 $ */ #ifndef _PAM_CONSTANTS_H_INCLUDED @@ -97,7 +97,8 @@ * XSSO 5.4 */ enum { - PAM_SILENT = 0x80000000, + /* some compilers promote 0x8000000 to long */ + PAM_SILENT = (-0x7fffffff - 1), PAM_DISALLOW_NULL_AUTHTOK = 0x1, PAM_ESTABLISH_CRED = 0x1, PAM_DELETE_CRED = 0x2,