From owner-svn-src-head@FreeBSD.ORG Sat Mar 13 12:58:39 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 672FC106571D; Sat, 13 Mar 2010 12:58:39 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 3C8F28FC12; Sat, 13 Mar 2010 12:58:39 +0000 (UTC) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id B060C46B65; Sat, 13 Mar 2010 07:58:38 -0500 (EST) Date: Sat, 13 Mar 2010 12:58:38 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Randall Stewart In-Reply-To: <201003122258.o2CMwqDM039077@svn.freebsd.org> Message-ID: References: <201003122258.o2CMwqDM039077@svn.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205104 - in head/sys: dev/xen/netback netinet netinet6 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2010 12:58:39 -0000 On Fri, 12 Mar 2010, Randall Stewart wrote: > The proper fix for the delayed SCTP checksum is to > have the delayed function take an argument as to the offset > to the SCTP header. This allows it to work for V4 and V6. > This of course means changing all callers of the function > to either pass the header len, if they have it, or create > it (ip_hl << 2 or sizeof(ip6_hdr)). It will become harder to MFC SCTP changes like this in the future, BTW. It's only good (bad) luck that this change doesn't break the KBI depended on by the ipdivert module. If SCTP had been enabled in the module (which it probably should be, with options SCTP in GENERIC), then the module would be broken, meaning that we couldn't MFC this change as-is. After MFCing this change, I recommend fixing ipdivert, but also increased caution in changing kernel interfaces that may be depended on by modules... Robert N M Watson Computer Laboratory University of Cambridge