From owner-cvs-all  Sat Sep 25 14:13:40 1999
Delivered-To: cvs-all@freebsd.org
Received: from emmi.physik.TU-Berlin.DE (emmi.physik.TU-Berlin.DE [130.149.160.103])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7CEF115328; Sat, 25 Sep 1999 14:13:10 -0700 (PDT)
	(envelope-from ibex@emmi.physik.TU-Berlin.DE)
Received: (from ibex@localhost)
	by emmi.physik.TU-Berlin.DE (8.9.3/8.9.3) id XAA51427;
	Sat, 25 Sep 1999 23:13:04 +0200 (CEST)
	(envelope-from ibex)
Date: Sat, 25 Sep 1999 23:13:04 +0200
From: Dirk Froemberg <dirk@freebsd.org>
To: Satoshi - Ports Wraith - Asami <asami@freebsd.org>
Cc: Andreas Klemm <andreas@freebsd.org>, cvs-committers@freebsd.org,
	cvs-all@freebsd.org
Subject: Re: cvs commit: ports/print/apsfilter Makefile
Message-ID: <19990925231304.A51257@physik.TU-Berlin.DE>
References: <199909251711.KAA00809@freefall.freebsd.org> <vqcso42lxba.fsf@silvia.hip.berkeley.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 1.0pre2i
In-Reply-To: <vqcso42lxba.fsf@silvia.hip.berkeley.edu>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

Hi Satoshi, hi Andreas!

On Sat, Sep 25, 1999 at 10:23:37AM -0700, Satoshi - Ports Wraith - Asami wrote:
>  *   Modified files:
>  *     print/apsfilter      Makefile 
>  *   Log:
>  *   added configure script with dialog utility like in apache13-php3 port,
>  *   that offers the user a menue, where he enters
>  *   	- PAPERSIZE
>  *   	- file type support for apsfilter

I jump in here because this was copied from apache13-php3 more or less.
So the same questions apply to apache13-php3. 8-)

> Thanks, but why are you putting the generated Makefile.inc in
> ${WRKDIRPREFIX}${.CURDIR} instead of ${WRKDIR}?  The latter will
> surely make your Makefile much simpler.

I don't remember if it was really necessary and otherwise would be like
sawing on a branch you are sitting on or if it was just a style issue
("Makefile.inc belongs to Makefile").

Anyway I don't think it hurts much to use ${WRKDIRPREFIX}${.CURDIR} here.

> Actually I don't even understand why you just didn't use pre-clean
> instead of copying the entire "clean" target from bsd.port.mk (which
> is usually not a very good idea) just to add a post-clean like
> functionality. ;)

A post-clean target is needed to clean the dependecies, too. If
pre-clean would be used, Makefile.inc would be deleted before
clean-depends is executed.

So a post-clean target in bsd.port.mk would be very convenient for
apsfilter and apache13-php[34]. BTW. clean is the only target in
bsd.port.mk that misses a corresponding post- target.

	Best regards Dirk

-- 
Dirk Froemberg


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message