From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri Apr  3 15:29:54 2015
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E75EA6B2
 for <freebsd-ports-bugs@FreeBSD.org>; Fri,  3 Apr 2015 15:29:54 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CCCF78C4
 for <freebsd-ports-bugs@FreeBSD.org>; Fri,  3 Apr 2015 15:29:54 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t33FTslg079765
 for <freebsd-ports-bugs@FreeBSD.org>; Fri, 3 Apr 2015 15:29:54 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 197588] [MAINTAINER] www/MT,russian/MT: update 5.2.12
Date: Fri, 03 Apr 2015 15:29:54 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: needs-qa, patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: marino@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-197588-13-aI63WjKk72@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-197588-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-197588-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Apr 2015 15:29:55 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197588

--- Comment #29 from John Marino <marino@FreeBSD.org> ---
takefu, you made several what we call "gratuitous" changes -- changes that
don't affect functionality, but screw up diff checks.

For example, 
line 1 \
line 2

changed to 
line 1\
line 2


First, there's no different functionally
second, the first example is preferred.  We want spaces before continuity
lines, even if it means "-V" shows two spaces between items
third, like I said, it's showing a diff which makes review more complex.

Please be careful about this.
I'm reverting some unnecessary changes to make my review easier.

Also, there was a change where you made the "mkdir" of the DBDIR invisible.  I
had it visible for a reason, but fine, we make it invisible.  However, then you
should have added it to the previous @${MKDIR} instead of keeping it as second
command.

-- 
You are receiving this mail because:
You are the assignee for the bug.