Date: Fri, 03 Apr 2015 15:29:54 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197588] [MAINTAINER] www/MT,russian/MT: update 5.2.12 Message-ID: <bug-197588-13-aI63WjKk72@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-197588-13@https.bugs.freebsd.org/bugzilla/> References: <bug-197588-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197588 --- Comment #29 from John Marino <marino@FreeBSD.org> --- takefu, you made several what we call "gratuitous" changes -- changes that don't affect functionality, but screw up diff checks. For example, line 1 \ line 2 changed to line 1\ line 2 First, there's no different functionally second, the first example is preferred. We want spaces before continuity lines, even if it means "-V" shows two spaces between items third, like I said, it's showing a diff which makes review more complex. Please be careful about this. I'm reverting some unnecessary changes to make my review easier. Also, there was a change where you made the "mkdir" of the DBDIR invisible. I had it visible for a reason, but fine, we make it invisible. However, then you should have added it to the previous @${MKDIR} instead of keeping it as second command. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197588-13-aI63WjKk72>