Date: Sat, 7 Nov 2015 09:36:08 -0800 From: Conrad Meyer <cem@FreeBSD.org> To: Konstantin Belousov <kib@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290493 - head/sys/sys Message-ID: <CAG6CVpUCAt7RniKNFOLOPs9U7aBBrdF3hUkSz5gAT1C4DDGZMQ@mail.gmail.com> In-Reply-To: <201511071233.tA7CXUKP032030@repo.freebsd.org> References: <201511071233.tA7CXUKP032030@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Missed that instance of intptr_t, sorry. Thanks for fixing it. I think we should also s/intptr_t/intmax_t/ in SYSCTL_HANDLER_ARGS. Thanks, Conrad On Sat, Nov 7, 2015 at 4:33 AM, Konstantin Belousov <kib@freebsd.org> wrote: > Author: kib > Date: Sat Nov 7 12:33:30 2015 > New Revision: 290493 > URL: https://svnweb.freebsd.org/changeset/base/290493 > > Log: > Correct the argument type in the sysctl_add_oid(9) prototype. On > ILP32 machines, intptr_t and intmax_t are different types. > > Submitted by: skra > > Modified: > head/sys/sys/sysctl.h > > Modified: head/sys/sys/sysctl.h > ============================================================================== > --- head/sys/sys/sysctl.h Sat Nov 7 12:30:43 2015 (r290492) > +++ head/sys/sys/sysctl.h Sat Nov 7 12:33:30 2015 (r290493) > @@ -949,7 +949,7 @@ extern char kern_ident[]; > /* Dynamic oid handling */ > struct sysctl_oid *sysctl_add_oid(struct sysctl_ctx_list *clist, > struct sysctl_oid_list *parent, int nbr, const char *name, int kind, > - void *arg1, intptr_t arg2, int (*handler)(SYSCTL_HANDLER_ARGS), > + void *arg1, intmax_t arg2, int (*handler)(SYSCTL_HANDLER_ARGS), > const char *fmt, const char *descr); > int sysctl_remove_name(struct sysctl_oid *parent, const char *name, int del, > int recurse); >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpUCAt7RniKNFOLOPs9U7aBBrdF3hUkSz5gAT1C4DDGZMQ>