Date: Sun, 25 Nov 2012 20:30:08 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r243142 - in head/sys: fs/nfsclient kern sys Message-ID: <20121125193008.GN1460@garage.freebsd.pl> In-Reply-To: <20121125162152.GA3013@kib.kiev.ua> References: <201211160825.qAG8P6v6047507@svn.freebsd.org> <20121124222408.GH1460@garage.freebsd.pl> <20121125162152.GA3013@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--i6vqABX3nJKXLk01
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Nov 25, 2012 at 06:21:52PM +0200, Konstantin Belousov wrote:
> On Sat, Nov 24, 2012 at 11:24:08PM +0100, Pawel Jakub Dawidek wrote:
> > I think we should move zpfind_locked() under 'pid <=3D PID_MAX':
> >=20
> > sx_slock(&allproc_lock);
> > if (pid <=3D PID_MAX) {
> > p =3D pfind_locked(pid);
> > if (p =3D=3D NULL && (flags & PGET_NOTWEXIT) =3D=3D 0)
> > p =3D zpfind_locked(pid);
> > } else if ((flags & PGET_NOTID) =3D=3D 0) {
> > p =3D pfind_tid_locked(pid);
> > } else {
> > p =3D NULL;
> > }
> > sx_sunlock(&allproc_lock);
> > if (p =3D=3D NULL)
> > return (ESRCH);
> >=20
>=20
> Yes, I agree. Please remove {} for one-line blocks.
If I need braces in one place, I put them into all the places so that
all the elses are aligned. style(9) does allow that.
--=20
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://tupytaj.pl
--i6vqABX3nJKXLk01
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlCyccAACgkQForvXbEpPzT3VgCggvcjjInHNPsmtHKUO+FJxA5m
LdkAoMzIIgZvEQpRuD/JIs4wW/jBweUr
=h3x4
-----END PGP SIGNATURE-----
--i6vqABX3nJKXLk01--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121125193008.GN1460>