From owner-freebsd-doc@FreeBSD.ORG Thu Jan 20 08:08:13 2005 Return-Path: Delivered-To: freebsd-doc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB04016A4CE for ; Thu, 20 Jan 2005 08:08:13 +0000 (GMT) Received: from gandalf.online.bg (gandalf.online.bg [217.75.128.9]) by mx1.FreeBSD.org (Postfix) with SMTP id 1A16043D58 for ; Thu, 20 Jan 2005 08:08:12 +0000 (GMT) (envelope-from roam@ringlet.net) Received: (qmail 10738 invoked from network); 20 Jan 2005 08:08:08 -0000 Received: from unknown (HELO straylight.ringlet.net) (213.16.36.109) by gandalf.online.bg with SMTP; 20 Jan 2005 08:08:08 -0000 Received: (qmail 3361 invoked by uid 1000); 20 Jan 2005 08:08:11 -0000 Date: Thu, 20 Jan 2005 10:08:11 +0200 From: Peter Pentchev To: Edwin Groothuis Message-ID: <20050120080811.GB1745@straylight.m.ringlet.net> Mail-Followup-To: Edwin Groothuis , FreeBSD-gnats-submit@FreeBSD.org, freebsd-doc@FreeBSD.org References: <20050119210153.27DE76131@k7.mavetju> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="H1spWtNR+x+ondvy" Content-Disposition: inline In-Reply-To: <20050119210153.27DE76131@k7.mavetju> User-Agent: Mutt/1.5.6i cc: freebsd-doc@FreeBSD.org cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: docs/76472: [patch] tell porters handbook about OPTIONS X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jan 2005 08:08:13 -0000 --H1spWtNR+x+ondvy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 20, 2005 at 08:01:53AM +1100, Edwin Groothuis wrote: [snip] > + > + > + <makevar>OPTIONS</makevar> Just a couple of minor comments; the text is great. > + > + > + Background > + The OPTIONS variable gives the user who > + installs the port a dialog with the available options and saves > + them to /var/db/ports/portname/options. Next > + time when the port has to be rebuild, the options are reused. Never > + again you have to remember all the twenty "Never again *will* you have...", perhaps? > + The value for default is either ON or > + OFF. Multiple repetitions of these three fields > + is allowed. "Multiple repetitions... *are* allowed" sounds a bit better to me... > + When the user runs the make config (or runs I don't think you need 'the' here, since 'command' is never displayed in the resulting text/HTML/whatever. I'd suggest 'When the user runs ...' > + make build for the first time), the framework will > + check for > + /var/db/ports/portname/options. > + If it doesn't exist, it will use the values of Maybe "If this file doesn't exist", to avoid confusion as to what the different 'it's mean :) > + OPTIONS to create a dialogbox where the options > + can be enabled or disabled. Then the options file is saved and the > + selected variables are set. The selected variables are only set when the port is actually being fetched/built/installed, and not in the user environment or anything, right? Maybe something like 'and the selected variables will be used when building the port'. [snip] > + Brokeness ITYM Brokenness :) Other than that, great work! G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@cnsys.bg roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 because I didn't think of a good beginning of it. --H1spWtNR+x+ondvy Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFB72bq7Ri2jRYZRVMRAtJiAKCMyUBXVDrkFSmMkE2/CvylcFCRCACZAZ7J QCRcitPhJscDPAkzYTeuhJ8= =3gYU -----END PGP SIGNATURE----- --H1spWtNR+x+ondvy--