From owner-freebsd-current Mon May 28 10:22:50 2001 Delivered-To: freebsd-current@freebsd.org Received: from gndrsh.dnsmgr.net (GndRsh.dnsmgr.net [198.145.92.4]) by hub.freebsd.org (Postfix) with ESMTP id 377F637B423; Mon, 28 May 2001 10:22:45 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.9.3/8.9.3) id KAA56879; Mon, 28 May 2001 10:22:33 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <200105281722.KAA56879@gndrsh.dnsmgr.net> Subject: Re: 'make includes' ownership patch In-Reply-To: <20010528113318.D32649@sunbay.com> from Ruslan Ermilov at "May 28, 2001 11:33:18 am" To: ru@FreeBSD.ORG (Ruslan Ermilov) Date: Mon, 28 May 2001 10:22:33 -0700 (PDT) Cc: kris@obsecurity.org (Kris Kennaway), current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > On Sat, May 26, 2001 at 03:06:00PM -0700, Kris Kennaway wrote: > > On Sat, May 26, 2001 at 02:59:22PM -0700, Kris Kennaway wrote: > > > Shouldn't the includes/Makefile be installing headers using > > > INCOWN/INCGRP instead of BINOWN/BINGRP? I ran into this when trying > > > to do a 'make includes' as a normal user. > > > > Oops, hit send too soon; more changes are required of the same form. > > Before I go to the trouble of doing those, I might as well get > > confirmation whether this is the right thing to do. > > > This was on my TODO. The only problem with INCOWN/INCGRP not being > used here is that they were introduced long after include/Makefile. And perhaps one should go read the commit message that introduced them... it was an experiment, a sample test designed to only be used in -current /usr/src/lib, that BDE, Sheldon and myself had long followon conversations about, and got dropped into the cracks. The name INC* is not clear as to be correct, per BDE it probably should be HDR* or HDRS* (I specifically avoided that since existing Makefiles used that, not knowing that BDE had seperately been eyeing HDRS* for what I ended up calling INC*.) Since, other commiters have ignored direct, and inderect requests not to propogate this INC* experiment, and it now infects all the way back to at least 3.x* and possibly 4.*, making it near impossible to clean up :-(. So feel free to ignore this email and change src/include/Makefile any way you wish... -- Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message