Date: Fri, 8 Feb 2002 16:58:40 -0800 From: John Merryweather Cooper <john_m_cooper@yahoo.com> To: Joe Clarke <marcus@marcuscom.com> Cc: sobomax@freebsd.org, gnome@freebsd.org Subject: Re: Why no GNOME for AbiWord? Message-ID: <20020208165840.A20983@johncoop.MSHOME> In-Reply-To: <1013214863.81141.43.camel@shumai.marcuscom.com>; from marcus@marcuscom.com on Fri, Feb 08, 2002 at 16:34:22 -0800 References: <1013214863.81141.43.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I consider this patch to be 100% Good Thing(tm). And I like my X
programs in the X_PREFIX, so I'm all in favor of the USE_X_PREFIX.
I would add ${PTHREAD_CFLAGS} to CPPFLAGS int the CONFIGURE_ENV as this
is the Right Thing(tm) to do for -STABLE (it makes no difference on
-CURRENT).
On 2002.02.08 16:34 Joe Clarke wrote:
> I noticed that AbiWord doesn't build with GNOME support. It also
> installs in ${LOCALBASE} instead of ${X11BASE}. Why is this? What
> about this patch for AbiWord? You could also add USE_X_PREFIX, but I
> haven't explicitly tested that.
>
> When you build with GNOME support, AbiWord makes itself look like part
> of GNOME Office. It uses the sound server, and uses GNOME icons. It
> still doesn't integrate into the Applications menu, but that could be
> fixed with a post-install task.
>
> Joe
>
>
>
> --- Makefile.orig Fri Feb 8 16:53:18 2002
> +++ Makefile Fri Feb 8 19:13:39 2002
> @@ -33,6 +33,7 @@
> USE_AUTOMAKE= yes
> USE_GMAKE= yes
> USE_GTK= yes
> +WANT_GNOME= yes
> AUTOMAKE= ${WRKSRC}/autogen.sh && ${FIXME}
> CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \
> LDFLAGS="-L${LOCALBASE}/lib -lgiconv"
> @@ -41,6 +42,18 @@
>
> 's|\$$\(libdir\)/\@PACKAGE\@|\$$\(datadir\)/\@PACKAGE\@|g
> ; \
> s|\@DEFS\@|-I${WRKSRC}/../libiconv/include
> \@DEFS\@|g'
>
> +.include <bsd.port.pre.mk>
> +
> +.if defined(HAVE_GNOME)
> +USE_GNOME= yes
> +PLIST_SUB+= GNOMEINSTALL=""
> +PLIST_SUB+= GNOMECOMMENT="@comment "
> +CONFIGURE_ARGS= --enable-gnome
> +.else
> +PLIST_SUB+= GNOMEINSTALL="@comment "
> +PLIST_SUB+= GNOMECOMMENT=""
> +.endif
> +
> post-patch:
> @giconv -f cp1251 -t koi8-u
> ${WRKSRC}/user/wp/strings/uk-UA.strings
> > \
> ${WRKDIR}/.uk-UA.strings
> @@ -54,4 +67,4 @@
> post-install:
> @${CAT} ${PKGMESSAGE}
>
> -.include <bsd.port.mk>
> +.include <bsd.port.post.mk>
>
> --- pkg-plist.orig Fri Feb 8 18:54:47 2002
> +++ pkg-plist Fri Feb 8 19:13:48 2002
> @@ -1,6 +1,6 @@
> bin/AbiWord
> bin/AbiWord_d
> -bin/AbiWord_s
> +%%GNOMECOMMENT%%bin/AbiWord_s
> bin/abiword
> bin/ttftool
> share/AbiSuite/AbiWord/help/de-DE/about.html
> @@ -570,6 +570,7 @@
> share/AbiSuite/icons/abiword_48.png
> share/AbiSuite/icons/abiword_48.tif
> share/AbiSuite/icons/abiword_48.xpm
> +%%GNOMEINSTALL%%share/AbiSuite/icons/abiword_logo.xpm
> share/AbiSuite/templates/normal.awt
> @dirrm share/AbiSuite/templates
> @dirrm share/AbiSuite/icons
>
--
_
| |V| / ' || MacroHard -- \
\_| | | \_, || the perfection of form over |
----------------------------------|| substance, marketing over |
Web: http://www.borgsdemons.com || performance, and greed over |
AIM: johnmcooper || design . . . |
=====================================================================/
Public Key: http://www.borgsdemons.com/Personal/pgpkey.asc |
=====================================================================\
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-gnome" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020208165840.A20983>