From nobody Thu Jun 12 02:59:19 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bHnLW18wdz5xxyn for ; Thu, 12 Jun 2025 02:59:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bHnLW0P2Xz3rKB for ; Thu, 12 Jun 2025 02:59:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-3135f3511bcso385574a91.0 for ; Wed, 11 Jun 2025 19:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1749697170; x=1750301970; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pCIfoyLE/5nPJnTlPoa6+dGZS7HdXxr8PP6Pn+bLIVE=; b=ZBSmvK4sLt5R6oLv3bY8QrOIMAM9AvU8NQFbqhk1iaU+6l3s0Eore6F52p3TKRxjy5 PhuN9uEKgIjBBeM6bGEwbQxf2CAYQP3Z08jxJ/hOSTNAQWufa8tUTvhqa1XqXSmdRZ/T 5yeJTC8dkJPlMig3118ZcMQIYTA2ecvd3kbmKR1MJTzFifJRYqgQ80s/O3Rr+la3+KbX QqJJF21RP6A/T4maGwl/8peL0U++TjLI4IlNJ/2/CngQN/N95R9b8XiLrSIKRTBeLdnq 7lS88OCnlTYpmzySVIto3LHI25VN/PKcpAe2q7YTzdWmcVyJgOIA4QCDHPCGaSzzWViQ P14A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749697170; x=1750301970; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pCIfoyLE/5nPJnTlPoa6+dGZS7HdXxr8PP6Pn+bLIVE=; b=kam1Ef+Fg6MCQ9NdwXq0qIrEn9Imz22LrggKn17mx6MZ1ISPZWiskNhZwgyHoBwVvH TtFH+f0ZJdsjG+4QWH/ZfBiDQjbWfqAUjc/EMDH8l64VV/i5+u7u5dvBBBmpIjwkM5sM Y8Y4SlWgKT8wTO4xM/TZrkUQOXGI84UfAcQweVMp38lY/AJG7Pi4O/+NVE3vu4GZFpCe uXQDkqBfZQ3NuDDoy+zCPWaJO31o8hzWuAgqmGHe9ImmE4ZZyXZsOSDBwSeTGcKAXYdg 81DZ8eS/g6goSzK5QYNSeNSmDaJeTUdV/jNxUuHAFhDKE+UnBmV10qqzxeyJShKl4lFs GXFQ== X-Forwarded-Encrypted: i=1; AJvYcCWx/rN43FB6UDWjstXp35PgfmhqBkfcLO69V9WwOiGStiVfMmgp4As0ln72+WT+gEdbjjpubVasbUcsspLltRlzJgZI@freebsd.org X-Gm-Message-State: AOJu0YxOG6XzkebLkHoX0xXg+qa4ZkkvfdKd4sb20OHbvVq0Z1zTw9Jp jrDnc74VII7gT8Nyi/5iJn1rbivh/bWDdC5lPURzkDff/tVQ/ZpGzzvI97bGu3veNUDgCOTouHe lYmUDc0ZBv4YkYujPfQHi5m44yM172qOvZ5RKPpvteA== X-Gm-Gg: ASbGnct4tT+GiYp/8GSGvEvNCWLEmyri53C9EcD9HSCDvqHI6bWHXGgglDqnBhAwetm GSL4q4g/flcLyiZ428qxSGamC2nul3BBwwoqmr4dlnBYF4ZT+lZo8y7lCRgEXQp5g/9gT9Z3izs hgRMt4s+T08cjww4Ch50SNLxNU+rhxAXCW0UoVaOoNmpydo2IxNvA9rA== X-Google-Smtp-Source: AGHT+IFWxrxzNjdu3zTMYX9GrjYlqFtBVyA3x+WbHaJeDW5SahKICdzDZSHFxwflXqntHTVXeWgp0aAaayNMrZwFuAM= X-Received: by 2002:a17:90b:4cc1:b0:312:959:dc4d with SMTP id 98e67ed59e1d1-313bfb9fe6amr2917607a91.7.1749697169950; Wed, 11 Jun 2025 19:59:29 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202506112316.55BNGeGh046207@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 11 Jun 2025 22:59:19 -0400 X-Gm-Features: AX0GCFsjl0G1Z3pYxZEuDb81OPo7R5kADs_0qk42emtXKvM8skBdsMdjDIe4SNA Message-ID: Subject: Re: git: 3d12567133bf - main - Add the POSIX sig2str(3) & str2sig(3) calls To: Shawn Webb Cc: Warner Losh , Ricardo Branco , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4bHnLW0P2Xz3rKB X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] On Wed, Jun 11, 2025 at 10:56=E2=80=AFPM Shawn Webb wrote: > > On Wed, Jun 11, 2025 at 11:16:40PM +0000, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D3d12567133bfb4082a5115f1= 6a71a865ff2af7fb > > > > commit 3d12567133bfb4082a5115f16a71a865ff2af7fb > > Author: Ricardo Branco > > AuthorDate: 2025-05-10 20:56:03 +0000 > > Commit: Warner Losh > > CommitDate: 2025-06-11 23:16:22 +0000 > > > > Add the POSIX sig2str(3) & str2sig(3) calls > > > > Signed-off-by: Ricardo Branco > > Reviewed by: imp, kib, des, jilles > > Pull Request: https://github.com/freebsd/freebsd-src/pull/1696 > > --- > > include/signal.h | 9 ++++ > > lib/libc/gen/Makefile.inc | 3 ++ > > lib/libc/gen/Symbol.map | 2 + > > lib/libc/gen/psignal.3 | 56 ++++++++++++++++++++++- > > lib/libc/gen/sig2str.c | 112 ++++++++++++++++++++++++++++++++++++++= ++++++++ > > 5 files changed, 180 insertions(+), 2 deletions(-) > > > > diff --git a/include/signal.h b/include/signal.h > > index c1d341f317f4..22fefb63568f 100644 > > --- a/include/signal.h > > +++ b/include/signal.h > > @@ -40,6 +40,10 @@ > > #include > > #endif > > > > +#if __POSIX_VISIBLE >=3D 202405 || __BSD_VISIBLE > > +#define SIG2STR_MAX 32 /* size of buffer required for sig2str() = */ > > +#endif > > Hey Warner and Ricardo, > > The above breaks building world when _FORTIFY_SOURCE=3D2. I've committed > in HardenedBSD a fix: > https://git.hardenedbsd.org/hardenedbsd/HardenedBSD/-/commit/0572db282c5a= 542fe0de52739932e91eade537ed > > I suppose that the !defined gate might not actually be desired, since > doing it the way I did might cause issues if third-party code defines > the macro to a value smaller than what libc was built with. I might > remove that gate. I don't think we need the !defined part of it... But what software is breaking? What's the error message? Maybe the fact it's undefined is pointing at a different bug... Warner