From owner-p4-projects@FreeBSD.ORG  Sat Sep 27 10:23:30 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9FCF3106568E; Sat, 27 Sep 2008 10:23:30 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 62D4F1065689
	for <perforce@FreeBSD.org>; Sat, 27 Sep 2008 10:23:29 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 51B178FC16
	for <perforce@FreeBSD.org>; Sat, 27 Sep 2008 10:23:29 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id m8RANTuk097168
	for <perforce@FreeBSD.org>; Sat, 27 Sep 2008 10:23:29 GMT
	(envelope-from ed@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id m8RANT2Q097166
	for perforce@freebsd.org; Sat, 27 Sep 2008 10:23:29 GMT
	(envelope-from ed@FreeBSD.org)
Date: Sat, 27 Sep 2008 10:23:29 GMT
Message-Id: <200809271023.m8RANT2Q097166@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	ed@FreeBSD.org using -f
From: Ed Schouten <ed@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 150555 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Sep 2008 10:23:30 -0000

http://perforce.freebsd.org/chv.cgi?CH=150555

Change 150555 by ed@ed_dull on 2008/09/27 10:22:38

	Add a little more sanity checking to tty_(timed)wait().
	
	In our current TTY layer design it isn't possible to sleep on a
	TTY that has been abandoned by the driver. Add an assertion to
	tty_(timed)wait() to disallow sleeping when the TTY is gone.

Affected files ...

.. //depot/projects/mpsafetty/sys/kern/tty.c#51 edit

Differences ...

==== //depot/projects/mpsafetty/sys/kern/tty.c#51 (text+ko) ====

@@ -1189,6 +1189,7 @@
 	tty_lock_assert(tp, MA_OWNED|MA_NOTRECURSED);
 #endif
 	tty_lock_assert(tp, MA_OWNED);
+	MPASS(!tty_gone(tp));
 
 	error = cv_wait_sig(cv, tp->t_mtx);
 
@@ -1214,6 +1215,7 @@
 	tty_lock_assert(tp, MA_OWNED|MA_NOTRECURSED);
 #endif
 	tty_lock_assert(tp, MA_OWNED);
+	MPASS(!tty_gone(tp));
 
 	error = cv_timedwait_sig(cv, tp->t_mtx, hz);