From owner-cvs-all Wed Feb 26 9:16:34 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB9AD37B401; Wed, 26 Feb 2003 09:16:29 -0800 (PST) Received: from creme-brulee.marcuscom.com (rdu57-17-158.nc.rr.com [66.57.17.158]) by mx1.FreeBSD.org (Postfix) with ESMTP id 86FAA43FBD; Wed, 26 Feb 2003 09:16:27 -0800 (PST) (envelope-from marcus@marcuscom.com) Received: from [10.2.1.4] (vpn-client-4.marcuscom.com [10.2.1.4]) by creme-brulee.marcuscom.com (8.12.7/8.12.7) with ESMTP id h1QHFbZX018692; Wed, 26 Feb 2003 12:15:37 -0500 (EST) (envelope-from marcus@marcuscom.com) Subject: Re: cvs commit: src/sys/netgraph ng_fec.c From: Joe Marcus Clarke To: Julian Elischer Cc: Bill Paul , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG In-Reply-To: References: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-zxcQzW8EFVAly8jgyxj0" Organization: MarcusCom, Inc. Message-Id: <1046279766.311.4.camel@gyros> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 Date: 26 Feb 2003 12:16:06 -0500 X-Spam-Status: No, hits=-33.0 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,PGP_SIGNATURE_2, QUOTED_EMAIL_TEXT,QUOTE_TWICE_1,REFERENCES, REPLY_WITH_QUOTES autolearn=ham version=2.50 X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --=-zxcQzW8EFVAly8jgyxj0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2003-02-26 at 02:41, Julian Elischer wrote: > On Tue, 25 Feb 2003, Bill Paul wrote: >=20 > > wpaul 2003/02/25 22:38:54 PST > >=20 > > Modified files: > > sys/netgraph ng_fec.c=20 > > Log: > > Attempt to make the ng_fec module play nice with BPF again. Things ha= ve > > changed since this code was written: > > =20 > > - The ng_ether_input_p hook only accepts two arguments now: the point= er > > to the ether header structure is gone. >=20 > The problem is that you should not be using ng_ether_input_p at all > that is a private interface between ng_ether.c and if_ethersubr.c. > You should be connecting a hook to ng_ether.c which will in turn > use ng_ether_input_p. > I have on my list (right after my real job(TM) and kernel threading > and some netgraph cleanups) to alter ng_fec to use the official > interface. > i.e. yu should be able to say: > ngctl fxp0: mkpeer fec lower lower1 > ngctl name fxp0:lower fec1 > ngctl fxp1: connect fec1: lower lower2 > ngctl fxp0: connect fec1: upper upper >=20 > and hook an fec module onto two ethernet interfaces. > (using fxp0 as the upper end) >=20 > as it is, having ng_fec loaded in the kernel produces an instant > coredump if ng_ether is also loaded as they fight over ng_ether's > private hook into the ethernet code. >=20 > As I said.. It's on my list .. but don't hold your breath. Well, whenever you need someone to test, I still have my -CURRENT/-STABLE fec test machine setup. I haven't tested Bill's latest patch, but last I did check, -CURRENT was still panicking under any load iff ng_fec was loaded as a module. Joe >=20 >=20 >=20 > > =20 > > - It's no longer necessary to cons up a fake ether header before pass= ing > > incoming packets to BPF_MTAP(). > > =20 > > ng_fec_input() has been modified to account for these two changes. > > Running tcpdump on fec0 should work now. > > =20 > > PR: kern/46720 > > =20 > > Revision Changes Path > > 1.4 +6 -16 src/sys/netgraph/ng_fec.c > >=20 >=20 >=20 > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe cvs-src" in the body of the message --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-zxcQzW8EFVAly8jgyxj0 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQA+XPZWb2iPiv4Uz4cRArBzAJ4/XHcQoLys/4NndDyCLPnfauNVswCeJl0k hFlJMGjl9uUJ+xgOOWHVZAM= =vPuu -----END PGP SIGNATURE----- --=-zxcQzW8EFVAly8jgyxj0-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message