From owner-freebsd-net Sun Aug 12 23:55:10 2001 Delivered-To: freebsd-net@freebsd.org Received: from InterJet.elischer.org (c421509-a.pinol1.sfba.home.com [24.7.86.9]) by hub.freebsd.org (Postfix) with ESMTP id CAD6037B40D for ; Sun, 12 Aug 2001 23:55:02 -0700 (PDT) (envelope-from julian@elischer.org) Received: from elischer.org (InterJet.elischer.org [192.168.1.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id XAA00513 for ; Sun, 12 Aug 2001 23:41:10 -0700 (PDT) Message-ID: <3B777442.59D83AC4@elischer.org> Date: Sun, 12 Aug 2001 23:31:30 -0700 From: Julian Elischer X-Mailer: Mozilla 4.7 [en] (X11; U; FreeBSD 5.0-CURRENT i386) X-Accept-Language: en, hu MIME-Version: 1.0 Cc: net@FreeBSD.ORG Subject: Re: IPV6/KAME/protosw integration cleanup References: <4246.997609202@itojun.org> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org note: I cannot respond to this address directly. JINMEI Tatuya / 神明達哉 wrote: > > >>>>> On Sun, 12 Aug 2001 18:40:02 +0900, > >>>>> itojun@iijlab.net said: > > >> When KAME was added the mesh was less that perfect but there was so much to > >> be done that some shortcuts needed to be taken. > >> > >> now that time has passed some of these can be cleaned up. > >> > >> 1/ Merging ipprotosw.h and protosw.h > >> 2/ removal of all varargs stuff from the kernel > >> (this revealing the mismatched prototypes they were hiding) > >> removal of lotso warnings from the KAME stuff. > > > the change does add pain to KAME integration side on upgrades. > > note that KAME codebase uses the same code across multiple *BSDs. > > please don't do this. If other BSDs WANT varargs for this they are crazier than I thought. > > I tend to agree with itojun. Although I understand FreeBSD guys want > to make code from KAME cleaner in terms of FreeBSD's own point of > view, it will make future merge from KAME to FreeBSD harder. This is > a trade-off issue, but at this moment, I think we'll still need > further merge from KAME to FreeBSD, so I'd prefer keeping the code "as > is" for a while. > Although I understand KAME guys want to make code from KAME cleaner in terms of KAME's own point of view, it will make future merge from Almost anywhere else to FreeBSD harder. varargs is not an acceptable solution. please find some other method. (make a macro start that is defined differently for each platform for example). -- +------------------------------------+ ______ _ __ | __--_|\ Julian Elischer | \ U \/ / hard at work in | / \ julian@elischer.org +------>x USA \ a very strange | ( OZ ) \___ ___ | country ! +- X_.---._/ presently in San Francisco \_/ \\ v To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message