From owner-svn-src-all@FreeBSD.ORG Fri Feb 20 23:01:27 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E636106566B; Fri, 20 Feb 2009 23:01:27 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 4BA918FC13; Fri, 20 Feb 2009 23:01:27 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n1KN1RWt041380; Fri, 20 Feb 2009 23:01:27 GMT (envelope-from marcel@svn.freebsd.org) Received: (from marcel@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n1KN1R93041379; Fri, 20 Feb 2009 23:01:27 GMT (envelope-from marcel@svn.freebsd.org) Message-Id: <200902202301.n1KN1R93041379@svn.freebsd.org> From: Marcel Moolenaar Date: Fri, 20 Feb 2009 23:01:27 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r188868 - head/sys/dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2009 23:01:28 -0000 Author: marcel Date: Fri Feb 20 23:01:27 2009 New Revision: 188868 URL: http://svn.freebsd.org/changeset/base/188868 Log: Don't read the TOC for DIOCGPROVIDERALIAS. This causes the acd code to create new provider (?), but not from an expected context, which results in a panic (GEOM topology not held). Modified: head/sys/dev/ata/atapi-cd.c Modified: head/sys/dev/ata/atapi-cd.c ============================================================================== --- head/sys/dev/ata/atapi-cd.c Fri Feb 20 22:46:24 2009 (r188867) +++ head/sys/dev/ata/atapi-cd.c Fri Feb 20 23:01:27 2009 (r188868) @@ -219,7 +219,10 @@ acd_geom_ioctl(struct g_provider *pp, u_ case CDIOCRESET: acd_test_ready(dev); break; - + + case DIOCGPROVIDERALIAS: + break; + default: acd_read_toc(dev); acd_prevent_allow(dev, 1);