Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 7 Sep 2017 09:34:07 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Christian Weisgerber <naddy@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r449357 - in head/net-p2p/mktorrent: . files
Message-ID:  <20170907093407.GA7480@FreeBSD.org>
In-Reply-To: <201709061910.v86JA8Rd002544@repo.freebsd.org>
References:  <201709061910.v86JA8Rd002544@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 06, 2017 at 07:10:08PM +0000, Christian Weisgerber wrote:
> New Revision: 449357
> URL: https://svnweb.freebsd.org/changeset/ports/449357
> 
> Log:
>   * Update to v1.1.
>   * Reset MAINTAINER.

Not mentioned in the log: move to GitHub (implementation raises some
questions, see below).

> ...
> -MASTER_SITES=	SF
> +MASTER_SITES=	https://github.com/Rudde/mktorrent/archive/
> +DISTNAME=	v${PORTVERSION}
> +DIST_SUBDIR=	${PORTNAME}

Why not use USE_GITHUB and avoid having to set MASTER_SITES and all these
DIST_SUBDIR dances?

> +WRKSRC= 	${WRKDIR}/${PORTNAME}-${PORTVERSION}

This line would also not be needed.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170907093407.GA7480>