Date: Sat, 21 Nov 2015 03:08:19 +0300 From: Andrey Chernov <ache@freebsd.org> To: Ravi Pokala <rpokala@mac.com>, Ravi Pokala <rpokala@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: "Sanderson, David" <dws@panasas.com> Subject: Re: svn commit: r291114 - head/lib/libc/gen Message-ID: <564FB5F3.1080301@freebsd.org> In-Reply-To: <28C3C55F-BF25-4DB2-AF05-B57F3F2CCAD5@panasas.com> References: <201511202236.tAKMaf06048447@repo.freebsd.org> <564FAAB0.6000600@freebsd.org> <28C3C55F-BF25-4DB2-AF05-B57F3F2CCAD5@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21.11.2015 2:57, Ravi Pokala wrote: > There's two different things at play - userland resources and kernel resources. Both "FILE *iop" and "struct pid *cur" are userland, while the descriptors in "pdes" are kernel. We clean up the descriptors in "pdes" in call cases, so we're not leaking kernel resources. You're right that "iop" (and "cur", which you didn't mention) appear to be leaked in the child, in that they're not explicitly cleaned up. But they get wiped away by the _execve(), so it doesn't matter. See my next reply. I care not about userland resources, but about fdopen() ability to set FD_CLOEXEC. -- http://ache.vniz.net/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?564FB5F3.1080301>