From owner-svn-src-all@FreeBSD.ORG Thu Sep 18 15:41:35 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DAEC0BDA; Thu, 18 Sep 2014 15:41:35 +0000 (UTC) Received: from mail-wg0-x22d.google.com (mail-wg0-x22d.google.com [IPv6:2a00:1450:400c:c00::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AECB8ABF; Thu, 18 Sep 2014 15:41:34 +0000 (UTC) Received: by mail-wg0-f45.google.com with SMTP id z12so1086587wgg.28 for ; Thu, 18 Sep 2014 08:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=8PrbGgbHMhuBjeveJk0onvdw9Nb6fyNACrzolmkQYIU=; b=IoDR8rH5WULthtECGOkdlBpjf3Qvhcz432g0TGooaWrYWXYVDW9ikQ4KCLSd4IgnJD 2tbdoyxkPlKvjdVUn6ZnbxkKFCw1BR/uqLZFrv63tPxMNRjggpM2rxSl5OYf7CQtXxnJ +r11y4cb9HndJ2OViNT/J8rMF7PdYdoQd7YytCuMNexSz/A521InccwDcLF0S26GDqx3 57CcXUDd0f5ne3XsJVNrGs0cRW+un/Z+fdJyFtLHRZulKKXbDxFIG1r8vovFgDUq04t3 Bq9/Pq/7q5Gqkf/0jxdyC7+XC41o4fY0d7t+f0bQx/wMQDdYkdQdnZsdrozQWHrFMq9p toFw== MIME-Version: 1.0 X-Received: by 10.180.189.18 with SMTP id ge18mr858wic.37.1411054892958; Thu, 18 Sep 2014 08:41:32 -0700 (PDT) Received: by 10.216.159.193 with HTTP; Thu, 18 Sep 2014 08:41:32 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: References: <201409180309.s8I39Zmh045601@svn.freebsd.org> <20140918051834.GD89442@FreeBSD.org> <20140918060435.GA5856@ns.kevlo.org> <1411024874.128099.168895241.4A95DCA1@webmail.messagingengine.com> Date: Thu, 18 Sep 2014 23:41:32 +0800 Message-ID: Subject: Re: svn commit: r271735 - head/sys/net From: Marcelo Araujo To: Adrian Chadd Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , Bruce Simpson , Gleb Smirnoff , "svn-src-head@freebsd.org" , Kevin Lo X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2014 15:41:36 -0000 Hello Adrian, I have a patch, but it is a hack on PF and some very ugly code. Not generic at all. As my hands are dirty now with it, if you don't have too much time, I can take a look on pfsense implementation. Best Regards, 2014-09-18 22:32 GMT+08:00 Adrian Chadd : > There is in pfsense. > > Let me see about twisting some arms again... :) > > > -a > > > On 18 September 2014 00:21, Bruce Simpson wrote: > > On Thu, 18 Sep 2014, at 07:04, Kevin Lo wrote: > >> Sorry, I overlooked that. Marcelo has a patch with 802.1p tagging > >> support, > >> I thought the patch was committed. > > > > I agree the comment change should be reverted. I changed if_ethersubr.c > > many years ago to decode 802.1p tags into the mbuf packet header if they > > are present. > > > > However, to my knowledge, there is no support (e.g. in the form of a > > DiffServ / IntServ mapping) further up in the stack. If someone plans to > > add this, great -- that would be needed for any form of tangible 802.1p > > support. > > > > -- > > BMS (sent via webmail) > > > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)